You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Mike Riley (Commented) (JIRA)" <ji...@apache.org> on 2011/11/28 00:12:40 UTC

[jira] [Commented] (THRIFT-1374) php autoload packages need to bootstrap the autoloader

    [ https://issues.apache.org/jira/browse/THRIFT-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158074#comment-13158074 ] 

Mike Riley commented on THRIFT-1374:
------------------------------------

This would prevent people from using a different autoloader than the default, I had always assumed that's why you need to include autoload.php manually. We could get around that by switching from __autoload to spl_autoload_register, but that would break compatibility for PHP < 5.1.2.

Not sure what the priorities on any of that would be.
                
> php autoload packages need to bootstrap the autoloader
> ------------------------------------------------------
>
>                 Key: THRIFT-1374
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1374
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>            Reporter: Dave Watson
>            Priority: Minor
>         Attachments: 0002-php-autoload-packages-need-to-bootstrap-the-autoload.patch
>
>
> From 51029ed4bcede7b511cbdb4976243cf628cc0c53 Mon Sep 17 00:00:00 2001
> From: Bill Fumerola <bi...@fb.com>
> Date: Mon, 8 Feb 2010 23:18:18 +0000
> Subject: [PATCH 2/9] php autoload packages need to bootstrap the autoloader
> Test Plan:
> generated scribe, saw the autoload in fb303, didn't see it in scribe
> Conflicts:
> 	compiler/cpp/src/generate/t_php_generator.cc
> ---
>  compiler/cpp/src/generate/t_php_generator.cc |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira