You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org> on 2013/09/11 21:12:57 UTC
[jira] [Commented] (TRINIDAD-2415) nested selectors not generated
correctly when used with icon selectors
[ https://issues.apache.org/jira/browse/TRINIDAD-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764644#comment-13764644 ]
Jeanne Waldman commented on TRINIDAD-2415:
------------------------------------------
Anand,
Could you give me more information --
What is the content of this selector? Is it an 'icon' selector (this turns into an Icon skinning framework object), or is it meant to be a style selector (one that gets written out to the css file). It sounds like it is a style selector that gets written out to the css file. The user should be using icon-style instead of -icon. You should see a warning on the console if you end with -icon.
.AFSomeAlias af|style-icon-style or .AFSomeAlias af|style-icon-style:hover
Do you get the error if the user uses the -icon-style?
If the user can change his selector name, then he should.
I agree that you should still fix this issue for those who used -icon as a style selector (even though they shouldn't have, but that isn't super clear to a user they shouldn't - except the warning on the console).
> nested selectors not generated correctly when used with icon selectors
> ----------------------------------------------------------------------
>
> Key: TRINIDAD-2415
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2415
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Skinning
> Affects Versions: 2.1.0-core
> Reporter: Anand V Nath
> Attachments: jira-2415.patch
>
>
> This bug is about a nested selector specified with an "-icon" selector.
> Eg: .AFSomeAlias af|style-icon or .AFSomeAlias af|style-icon:hover
> This gets rendered as
> AFSomeAlias af_style-icon
> AFSomeAlias af_style-icon:hover
> The reason why this happens is that we strip out the leading dot for the icon styles. But it is required only for the icon alias cases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira