You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Savalek <gi...@git.apache.org> on 2018/03/06 14:49:38 UTC
[GitHub] zeppelin pull request #2841: [Zeppelin 3224] - Fix "ultimate" visualization
GitHub user Savalek opened a pull request:
https://github.com/apache/zeppelin/pull/2841
[Zeppelin 3224] - Fix "ultimate" visualization
### What is this PR for?
This PR fixes problems with incorrect data visualization using "ultimate". With certain aggregations, the data was not displayed. Also PR improves sorting by columns / rows, before PR it compared by Unicode encoding, but now if there are only numeric data on the axis, sorting will be by values.
### What type of PR is it?
[Bug Fix & Improvement]
### What is the Jira issue?
[ZEPPELIN-3224](https://issues.apache.org/jira/browse/ZEPPELIN-3224)
### Screenshots (if appropriate)
**Error:**
**Now:**
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Savalek/zeppelin ZEPPELIN-3224
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2841.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2841
----
commit 94026be392c871563d3cac4889c71d6016f6e940
Author: Savalek <de...@...>
Date: 2018-02-01T14:27:08Z
fix graph display
commit 33676b4682064712a8e96f3283c2910204bd01ed
Author: Savalek <de...@...>
Date: 2018-02-05T14:55:13Z
fix XY legend sort for numbers
commit eab5d86d21dc19cc57cfac482107a555e1404980
Author: Savalek <de...@...>
Date: 2018-02-12T09:40:08Z
Merge branch 'master' into ZEPPELIN-3224
commit 9583f2ccea85b1da8810d2c499a5f0afaed48952
Author: Savalek <de...@...>
Date: 2018-02-26T08:44:37Z
small fix
commit ba7a6e3e442dced1439ae21cd688099f0584b6f1
Author: tinkoff-dwh <ti...@...>
Date: 2018-03-04T18:31:04Z
Merge branch 'master' into ZEPPELIN-3224
# Conflicts:
# zeppelin-web/src/app/tabledata/advanced-transformation-util.js
# zeppelin-web/src/app/tabledata/tabledata.js
commit dc78f3d2bfd6c9c97f28f0f53af762195377881c
Author: Savalek <de...@...>
Date: 2018-03-05T07:42:28Z
code style fix
commit 17d3f8d0e1530e52d5321aebbed7312ccd749592
Author: Savalek <de...@...>
Date: 2018-03-05T14:35:02Z
add tests for sortWithNumberSupport()
commit d4b2a4913d9e45b326fd09ba2349903e7e7b34c6
Author: Savalek <de...@...>
Date: 2018-03-05T14:48:55Z
add test
commit e7d1cd7cc907a55be2e2e6771014b8c1b15f6cff
Author: tinkoff-dwh <ti...@...>
Date: 2018-03-06T09:31:40Z
Merge branch 'master' into ZEPPELIN-3224
commit 5c866b183cb98fe4654bcd1361d1a936d5c94eda
Author: tinkoff-dwh <ti...@...>
Date: 2018-03-06T11:53:35Z
small fix
----
---
[GitHub] zeppelin pull request #2841: [Zeppelin-3224] - Fix "ultimate" visualization
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2841
---
[GitHub] zeppelin issue #2841: [Zeppelin-3224] - Fix "ultimate" visualization
Posted by Savalek <gi...@git.apache.org>.
Github user Savalek commented on the issue:
https://github.com/apache/zeppelin/pull/2841
@felixcheung
I found a better solution for checking for a number.
---
[GitHub] zeppelin issue #2841: [Zeppelin-3224] - Fix "ultimate" visualization
Posted by Savalek <gi...@git.apache.org>.
Github user Savalek commented on the issue:
https://github.com/apache/zeppelin/pull/2841
Will merge?
---
[GitHub] zeppelin issue #2841: [Zeppelin-3224] - Fix "ultimate" visualization
Posted by Savalek <gi...@git.apache.org>.
Github user Savalek commented on the issue:
https://github.com/apache/zeppelin/pull/2841
@Leemoonsoo
I have confused the functional with parseInt().
I fixed it.
---
[GitHub] zeppelin issue #2841: [Zeppelin-3224] - Fix "ultimate" visualization
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2841
Thanks @Savalek for great improvement. LGTM and merge to master and branch-0.8 if no further comment.
---