[GitHub] [airflow] potiuk edited a comment on issue #17240: bash operator overrides environment variables instead of updating them

[GitBox <gi...@apache.org>]

potiuk edited a comment on issue #17240:
URL: https://github.com/apache/airflow/issues/17240#issuecomment-887285188


   Yep. It is explicitly mentioned in the documentation of BashOperator:
   
   ```
       :param env: If env is not None, it must be a dict that defines the
           environment variables for the new process; these are used instead
           of inheriting the current process environment, which is the default
           behavior. (templated)
       :type env: dict
   ```
   
   However @omriAl, if you feel you need the case where env have to be additive, I would encourage you to make a PR and this feature. I imagine, this could be an extra flag with default = True (`replace_os_env=True`)  or similar and if it is set to`False` the os env will be retained and the env values specified would just override those specified ones. It's an easy fix and I encourage you to contribute it.
   
   Would you like to add it ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org