You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/29 20:41:46 UTC
[GitHub] [beam] pabloem opened a new pull request, #22942: Improve BQ test utils to support JSON in a more simple manner
pabloem opened a new pull request, #22942:
URL: https://github.com/apache/beam/pull/22942
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22942:
URL: https://github.com/apache/beam/pull/22942#issuecomment-1230839805
r: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22942:
URL: https://github.com/apache/beam/pull/22942#issuecomment-1233385120
Run Java_Examples_Dataflow PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22942:
URL: https://github.com/apache/beam/pull/22942#issuecomment-1233516522
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22942:
URL: https://github.com/apache/beam/pull/22942#issuecomment-1233516873
errors unrelated. Feel free to review @Abacn
Errors in previous run: https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/23775/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #22942:
URL: https://github.com/apache/beam/pull/22942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22942:
URL: https://github.com/apache/beam/pull/22942#issuecomment-1233124905
feels like jenkins is targeting me personally : ) lol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22942:
URL: https://github.com/apache/beam/pull/22942#issuecomment-1234398673
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22942:
URL: https://github.com/apache/beam/pull/22942#issuecomment-1233286962
uggg these don't repro in my local env
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22942:
URL: https://github.com/apache/beam/pull/22942#issuecomment-1231142862
Run Java PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22942:
URL: https://github.com/apache/beam/pull/22942#issuecomment-1231142777
thanks @Abacn - I've added an explanation on the top comment of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22942:
URL: https://github.com/apache/beam/pull/22942#issuecomment-1230847223
Thanks for the fix. Could you please providing some context of the change, like what current issue we have using INT32?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22942:
URL: https://github.com/apache/beam/pull/22942#issuecomment-1233244656
Run Java_Examples_Dataflow_Java11 PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22942:
URL: https://github.com/apache/beam/pull/22942#issuecomment-1232438630
Retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22942:
URL: https://github.com/apache/beam/pull/22942#issuecomment-1233348052
Run Java PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem closed pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem closed pull request #22942: Improve BQ test utils to support JSON in a more simple manner
URL: https://github.com/apache/beam/pull/22942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22942:
URL: https://github.com/apache/beam/pull/22942#issuecomment-1233226069
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22942:
URL: https://github.com/apache/beam/pull/22942#issuecomment-1230840944
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22942:
URL: https://github.com/apache/beam/pull/22942#issuecomment-1231928279
Run Java PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem closed pull request #22942: Improve BQ test utils to support JSON in a more simple manner
Posted by GitBox <gi...@apache.org>.
pabloem closed pull request #22942: Improve BQ test utils to support JSON in a more simple manner
URL: https://github.com/apache/beam/pull/22942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org