[jira] Resolved: (HARMONY-5656) [drlvm][port][signals] VM does not show assertion dialog on failed asserts

["Gregory Shimansky (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HARMONY-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky resolved HARMONY-5656.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0M6

Patch is applied at 642236.

> [drlvm][port][signals] VM does not show assertion dialog on failed asserts
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-5656
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5656
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: Windows
>            Reporter: Ilya Berezhniuk
>            Assignee: Gregory Shimansky
>             Fix For: 5.0M6
>
>         Attachments: assert_patch_03_2.patch
>
>
> When an assertion fired, VM does not show assertion dialog on Windows regardless of "vm.assert_dialog" property.
> The only case when assertion is displayed in a dialog is when crash handler is not initialized yet.
> The problem appears because in current crash handler design all CRT events are set up in crash handler initialization to print comsole message and do not display a dialog.
> The sceme supposed to re-enable CRT event setting in VEH. The problem with assert() is that the signal is caught neither in VEH nor in CRT handler.
> I can see 2 approaches to fix the problem:
> 1) Change CRT settings immediately when crash handler output flags are changed. This method introduces additional platform dependency and thus does not look good for me, but it shoul work stably.
> 2) SIGABRT handler can be registered on Windows, but Unix-like signals handling looks ugly in Windows environment.
> I'm going to try both methods, and provide a patch for working one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.