You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/07/31 10:47:01 UTC
[GitHub] [hadoop-ozone] lokeshj1703 commented on a change in pull request #1231: HDDS-3994. Make retry policy can be set by configuration.
lokeshj1703 commented on a change in pull request #1231:
URL: https://github.com/apache/hadoop-ozone/pull/1231#discussion_r463539752
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
##########
@@ -112,6 +112,18 @@
public static final String
DFS_CONTAINER_RATIS_LEADER_PENDING_BYTES_LIMIT_DEFAULT = "1GB";
+ public static final String DFS_RATIS_CLIENT_REQUEST_RETRY_POLICY =
+ "dfs.ratis.client.request.retry.policy";
+
+ public static final String DFS_RATIS_CLIENT_REQUEST_MAX_RETRIES_KEY =
+ "dfs.ratis.client.request.max.retries";
+ public static final int DFS_RATIS_CLIENT_REQUEST_MAX_RETRIES_DEFAULT = 180;
+ public static final String DFS_RATIS_CLIENT_REQUEST_RETRY_INTERVAL_KEY =
+ "dfs.ratis.client.request.retry.interval";
+ public static final TimeDuration
+ DFS_RATIS_CLIENT_REQUEST_RETRY_INTERVAL_DEFAULT =
+ TimeDuration.valueOf(1000, TimeUnit.MILLISECONDS);
+
Review comment:
Can we add these configs to RatisClientConfig class? I would also suggest renaming some of the configs to match the existing configs like hdds.ratis.client.retrylimited.retry.interval or sth similar. This would make it easier to distinguish between the configs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org