[jira] [Commented] (SOLR-8385) Narrow StreamFactory.withFunctionName clazz parameter to prevent misconfiguration.

["Jason Gerlowski (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-8385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061370#comment-15061370 ] 

Jason Gerlowski commented on SOLR-8385:
---------------------------------------

This is pretty trivial, both in value and in complexity.  If it gets lost because of lack of importance, that's fine with me.  Just wanted to give it a bump to make sure it's not getting lost b/c of lack of eyes.

> Narrow StreamFactory.withFunctionName clazz parameter to prevent misconfiguration.
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-8385
>                 URL: https://issues.apache.org/jira/browse/SOLR-8385
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ
>    Affects Versions: Trunk
>            Reporter: Jason Gerlowski
>            Priority: Trivial
>              Labels: easyfix
>             Fix For: Trunk
>
>         Attachments: SOLR-8385.patch
>
>
> Currently, {{StreamFactory}} has several overloaded {{withFunctionName}} methods.  One of these, takes two parameters: a {{String}} functionName, and a {{Class}} implementation type.
> This second parameter is a little too generic, because it's really only ever valid for a small, small subset of classes (i.e. {{Class<? extends Expressible}} ).  Narrowing the type of this parameter is a small step towards preventing accidental misconfiguration of a {{StreamFactory}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org