[GitHub] spark pull request #20243: [SPARK-23052][SS] Migrate ConsoleSink to data sou...

[tdas <gi...@git.apache.org>]

Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20243#discussion_r161324843
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/ConsoleWriter.scala ---
    @@ -0,0 +1,56 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution.streaming.sources
    +
    +import org.apache.spark.internal.Logging
    +import org.apache.spark.sql.{Row, SparkSession}
    +import org.apache.spark.sql.sources.v2.writer.{DataSourceV2Writer, DataWriterFactory, WriterCommitMessage}
    +import org.apache.spark.sql.types.StructType
    +
    +class ConsoleWriter(batchId: Long, schema: StructType, options: Map[String, String])
    +    extends DataSourceV2Writer with Logging {
    +  // Number of rows to display, by default 20 rows
    +  private val numRowsToShow = options.get("numRows").map(_.toInt).getOrElse(20)
    --- End diff --
    
    I am not sure `get("numRows")` on this options map is case-insensitive. Why not just pass on the DataSoureV2Options directly to this writer and use that directly? That is already case-insensitive.
    
    In fact that same pattern should be used for all v2 reader/writer (verify this for Kafka continuous).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org