You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by nsuke <gi...@git.apache.org> on 2017/11/01 15:15:18 UTC

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

Github user nsuke commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1084#discussion_r148288455
  
    --- Diff: compiler/cpp/src/thrift/generate/t_swift_generator.cc ---
    @@ -245,22 +297,30 @@ class t_swift_generator : public t_oop_generator {
      */
     void t_swift_generator::init_generator() {
       // Make output directory
    -  MKDIR(get_out_dir().c_str());
    +  string module = get_real_swift_module(program_);
    +  string out_dir = get_out_dir();
    +  string module_path = out_dir;
    +  string name = capitalize(program_name_);
    +  if (namespaced_ and !module.empty()) {
    --- End diff --
    
    I just noticed that this broke Windows build.
    It seems that VC++ does not support alternative keywords in our settings.
     Can you replace`and` with `&&` ? We'll see if it fixes the build.


---