You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/12/10 22:06:13 UTC

Re: Review Request 54618: Windows: Added trivially passable tests to build.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54618/
-----------------------------------------------------------

(Updated Dec. 10, 2016, 10:06 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Changes
-------

Added all Agent tests that trivially pass to the Windows build.


Summary (updated)
-----------------

Windows: Added trivially passable tests to build.


Bugs: MESOS-6700, MESOS-6704, MESOS-6710, MESOS-6711, and MESOS-6716
    https://issues.apache.org/jira/browse/MESOS-6700
    https://issues.apache.org/jira/browse/MESOS-6704
    https://issues.apache.org/jira/browse/MESOS-6710
    https://issues.apache.org/jira/browse/MESOS-6711
    https://issues.apache.org/jira/browse/MESOS-6716


Repository: mesos


Description (updated)
-------

This commit will resolve MESOS-6700, MESOS-6704, MESOS-6710, MESOS-6716,
and MESOS-6711 by trivially adding the relevant test files to the
Windows build.


Diffs (updated)
-----

  src/tests/CMakeLists.txt d49e44e91c04b0471d227092b648b29ff9286e75 

Diff: https://reviews.apache.org/r/54618/diff/


Testing
-------


Thanks,

Alex Clemmer

Re: Review Request 54618: Windows: Added trivially passable tests to build.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54618/#review159367
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Dec. 10, 2016, 4:42 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54618/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2016, 4:42 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-6700, MESOS-6704, MESOS-6710, MESOS-6711, and MESOS-6716
>     https://issues.apache.org/jira/browse/MESOS-6700
>     https://issues.apache.org/jira/browse/MESOS-6704
>     https://issues.apache.org/jira/browse/MESOS-6710
>     https://issues.apache.org/jira/browse/MESOS-6711
>     https://issues.apache.org/jira/browse/MESOS-6716
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit will resolve MESOS-6700, MESOS-6704, MESOS-6710, MESOS-6716,
> and MESOS-6711 by trivially adding the relevant test files to the
> Windows build.
> 
> 
> Diffs
> -----
> 
>   src/tests/CMakeLists.txt 0966b7f283ea2ce646a417e81b6dfe1134a7188c 
> 
> Diff: https://reviews.apache.org/r/54618/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 54618: Windows: Added trivially passable tests to build.

Posted by Joseph Wu <jo...@mesosphere.io>.

> On Dec. 15, 2016, 2:06 p.m., Joseph Wu wrote:
> > src/tests/CMakeLists.txt, line 93
> > <https://reviews.apache.org/r/54618/diff/4/?file=1581392#file1581392line93>
> >
> >     Looks like all three of these ExceptionTests are aborting on Windows (Mesos HEAD = 406e5f3700e179c50292b62912c2a94f9162b21b).  
> >     
> >     Glog does not print stack traces on Windows, but it appears to be a call to `Result::get` where the Result is either None or Error.

Oops, nevermind.  I forget to apply this in the chain: https://reviews.apache.org/r/53706/


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54618/#review159375
-----------------------------------------------------------


On Dec. 10, 2016, 4:42 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54618/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2016, 4:42 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-6700, MESOS-6704, MESOS-6710, MESOS-6711, and MESOS-6716
>     https://issues.apache.org/jira/browse/MESOS-6700
>     https://issues.apache.org/jira/browse/MESOS-6704
>     https://issues.apache.org/jira/browse/MESOS-6710
>     https://issues.apache.org/jira/browse/MESOS-6711
>     https://issues.apache.org/jira/browse/MESOS-6716
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit will resolve MESOS-6700, MESOS-6704, MESOS-6710, MESOS-6716,
> and MESOS-6711 by trivially adding the relevant test files to the
> Windows build.
> 
> 
> Diffs
> -----
> 
>   src/tests/CMakeLists.txt 0966b7f283ea2ce646a417e81b6dfe1134a7188c 
> 
> Diff: https://reviews.apache.org/r/54618/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 54618: Windows: Added trivially passable tests to build.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54618/#review159375
-----------------------------------------------------------




src/tests/CMakeLists.txt (line 93)
<https://reviews.apache.org/r/54618/#comment230358>

    Looks like all three of these ExceptionTests are aborting on Windows (Mesos HEAD = 406e5f3700e179c50292b62912c2a94f9162b21b).  
    
    Glog does not print stack traces on Windows, but it appears to be a call to `Result::get` where the Result is either None or Error.


- Joseph Wu


On Dec. 10, 2016, 4:42 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54618/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2016, 4:42 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-6700, MESOS-6704, MESOS-6710, MESOS-6711, and MESOS-6716
>     https://issues.apache.org/jira/browse/MESOS-6700
>     https://issues.apache.org/jira/browse/MESOS-6704
>     https://issues.apache.org/jira/browse/MESOS-6710
>     https://issues.apache.org/jira/browse/MESOS-6711
>     https://issues.apache.org/jira/browse/MESOS-6716
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit will resolve MESOS-6700, MESOS-6704, MESOS-6710, MESOS-6716,
> and MESOS-6711 by trivially adding the relevant test files to the
> Windows build.
> 
> 
> Diffs
> -----
> 
>   src/tests/CMakeLists.txt 0966b7f283ea2ce646a417e81b6dfe1134a7188c 
> 
> Diff: https://reviews.apache.org/r/54618/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 54618: Windows: Added trivially passable tests to build.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54618/
-----------------------------------------------------------

(Updated Dec. 11, 2016, 12:42 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Changes
-------

Remove flakey tests.


Bugs: MESOS-6700, MESOS-6704, MESOS-6710, MESOS-6711, and MESOS-6716
    https://issues.apache.org/jira/browse/MESOS-6700
    https://issues.apache.org/jira/browse/MESOS-6704
    https://issues.apache.org/jira/browse/MESOS-6710
    https://issues.apache.org/jira/browse/MESOS-6711
    https://issues.apache.org/jira/browse/MESOS-6716


Repository: mesos


Description
-------

This commit will resolve MESOS-6700, MESOS-6704, MESOS-6710, MESOS-6716,
and MESOS-6711 by trivially adding the relevant test files to the
Windows build.


Diffs (updated)
-----

  src/tests/CMakeLists.txt 0966b7f283ea2ce646a417e81b6dfe1134a7188c 

Diff: https://reviews.apache.org/r/54618/diff/


Testing
-------


Thanks,

Alex Clemmer

Re: Review Request 54618: Windows: Added trivially passable tests to build.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54618/
-----------------------------------------------------------

(Updated Dec. 10, 2016, 10:19 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Changes
-------

Fixed for staleness.


Bugs: MESOS-6700, MESOS-6704, MESOS-6710, MESOS-6711, and MESOS-6716
    https://issues.apache.org/jira/browse/MESOS-6700
    https://issues.apache.org/jira/browse/MESOS-6704
    https://issues.apache.org/jira/browse/MESOS-6710
    https://issues.apache.org/jira/browse/MESOS-6711
    https://issues.apache.org/jira/browse/MESOS-6716


Repository: mesos


Description
-------

This commit will resolve MESOS-6700, MESOS-6704, MESOS-6710, MESOS-6716,
and MESOS-6711 by trivially adding the relevant test files to the
Windows build.


Diffs (updated)
-----

  src/tests/CMakeLists.txt 0966b7f283ea2ce646a417e81b6dfe1134a7188c 

Diff: https://reviews.apache.org/r/54618/diff/


Testing
-------


Thanks,

Alex Clemmer