You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/09/17 10:09:55 UTC

Review Request 38452: Updated C++ style guide for namespace usage

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38452/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Bugs: MESOS-3450
    https://issues.apache.org/jira/browse/MESOS-3450


Repository: mesos


Description
-------

Updated C++ style guide for namespace usage


Diffs
-----

  docs/mesos-c++-style-guide.md f1ed32aa845f7cfc85d002f4306a3c32e2eeb1d6 

Diff: https://reviews.apache.org/r/38452/diff/


Testing
-------


Thanks,

Guangya Liu

Re: Review Request 38452: Updated C++ style guide for namespace usage

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38452/#review99363
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38452]

All tests passed.

- Mesos ReviewBot


On Sept. 17, 2015, 8:09 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38452/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 8:09 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3450
>     https://issues.apache.org/jira/browse/MESOS-3450
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated C++ style guide for namespace usage
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md f1ed32aa845f7cfc85d002f4306a3c32e2eeb1d6 
> 
> Diff: https://reviews.apache.org/r/38452/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38452: Updated C++ style guide for namespace usage

Posted by Guangya Liu <gy...@gmail.com>.

> On 九月 23, 2015, 5:47 p.m., Ben Mahler wrote:
> > It seems good to qualify how we're different from the google style guide here. It seems the main difference is that we avoid the using statements inside functions / classes for the most part.
> > 
> > Also not your fault but we're talking about namespace aliases and using statements in the "naming" section, which seems strange.

Thanks Ben. I was moving this section to "Namespace Names", hope it is OK.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38452/#review100240
-----------------------------------------------------------


On 九月 17, 2015, 8:09 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38452/
> -----------------------------------------------------------
> 
> (Updated 九月 17, 2015, 8:09 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3450
>     https://issues.apache.org/jira/browse/MESOS-3450
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated C++ style guide for namespace usage
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md f1ed32aa845f7cfc85d002f4306a3c32e2eeb1d6 
> 
> Diff: https://reviews.apache.org/r/38452/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38452: Updated C++ style guide for namespace usage

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38452/#review100240
-----------------------------------------------------------


It seems good to qualify how we're different from the google style guide here. It seems the main difference is that we avoid the using statements inside functions / classes for the most part.

Also not your fault but we're talking about namespace aliases and using statements in the "naming" section, which seems strange.

- Ben Mahler


On Sept. 17, 2015, 8:09 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38452/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 8:09 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3450
>     https://issues.apache.org/jira/browse/MESOS-3450
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated C++ style guide for namespace usage
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md f1ed32aa845f7cfc85d002f4306a3c32e2eeb1d6 
> 
> Diff: https://reviews.apache.org/r/38452/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38452: Updated C++ style guide for namespace usage

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38452/#review101038
-----------------------------------------------------------



docs/mesos-c++-style-guide.md (lines 41 - 43)
<https://reviews.apache.org/r/38452/#comment158342>

    It looks like we should mirror the structure of Google's C++ style guide here to make the differences more clear.
    
    So these belong in: 'Scoping' -> 'Namespaces'
    
    See: http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespaces
    
    Can you add a 'Scoping' section above and have 'Namespaces' as the subsection with the content you've added here?


- Ben Mahler


On Sept. 24, 2015, 2:20 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38452/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 2:20 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3450
>     https://issues.apache.org/jira/browse/MESOS-3450
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated C++ style guide for namespace usage
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 570ea6873ffc2cc8ec190ec3aa81986e3f3cbc95 
> 
> Diff: https://reviews.apache.org/r/38452/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38452: Updated C++ style guide for namespace usage

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38452/#review101044
-----------------------------------------------------------

Ship it!


Thanks! I'll get this committed shortly.


docs/mesos-c++-style-guide.md (line 11)
<https://reviews.apache.org/r/38452/#comment158349>

    s/##/###/ here


- Ben Mahler


On Sept. 29, 2015, 11:43 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38452/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 11:43 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3450
>     https://issues.apache.org/jira/browse/MESOS-3450
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated C++ style guide for namespace usage
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 570ea6873ffc2cc8ec190ec3aa81986e3f3cbc95 
> 
> Diff: https://reviews.apache.org/r/38452/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38452: Updated C++ style guide for namespace usage

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38452/
-----------------------------------------------------------

(Updated 九月 29, 2015, 11:43 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-3450
    https://issues.apache.org/jira/browse/MESOS-3450


Repository: mesos


Description
-------

Updated C++ style guide for namespace usage


Diffs (updated)
-----

  docs/mesos-c++-style-guide.md 570ea6873ffc2cc8ec190ec3aa81986e3f3cbc95 

Diff: https://reviews.apache.org/r/38452/diff/


Testing
-------


Thanks,

Guangya Liu

Re: Review Request 38452: Updated C++ style guide for namespace usage

Posted by Guangya Liu <gy...@gmail.com>.

> On 九月 29, 2015, 11:30 p.m., Ben Mahler wrote:
> > docs/mesos-c++-style-guide.md, lines 41-45
> > <https://reviews.apache.org/r/38452/diff/3/?file=1087466#file1087466line41>
> >
> >     To mirror the google style guide, can we place this before 'Naming'?

Done


> On 九月 29, 2015, 11:30 p.m., Ben Mahler wrote:
> > docs/mesos-c++-style-guide.md, line 45
> > <https://reviews.apache.org/r/38452/diff/3/?file=1087466#file1087466line45>
> >
> >     Add the following trailing sentence:
> >     
> >     ```
> >     ... you want to use. These should only be present at the top of the .cpp file.
> >     ```

Done


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38452/#review101041
-----------------------------------------------------------


On 九月 29, 2015, 11:43 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38452/
> -----------------------------------------------------------
> 
> (Updated 九月 29, 2015, 11:43 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3450
>     https://issues.apache.org/jira/browse/MESOS-3450
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated C++ style guide for namespace usage
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 570ea6873ffc2cc8ec190ec3aa81986e3f3cbc95 
> 
> Diff: https://reviews.apache.org/r/38452/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38452: Updated C++ style guide for namespace usage

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38452/#review101041
-----------------------------------------------------------

Ship it!


Thanks for your patience! Just a couple of cleanups and I can get this committed for you.


docs/mesos-c++-style-guide.md (lines 41 - 45)
<https://reviews.apache.org/r/38452/#comment158344>

    To mirror the google style guide, can we place this before 'Naming'?



docs/mesos-c++-style-guide.md (line 45)
<https://reviews.apache.org/r/38452/#comment158345>

    Add the following trailing sentence:
    
    ```
    ... you want to use. These should only be present at the top of the .cpp file.
    ```


- Ben Mahler


On Sept. 29, 2015, 11:04 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38452/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 11:04 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3450
>     https://issues.apache.org/jira/browse/MESOS-3450
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated C++ style guide for namespace usage
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 570ea6873ffc2cc8ec190ec3aa81986e3f3cbc95 
> 
> Diff: https://reviews.apache.org/r/38452/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38452: Updated C++ style guide for namespace usage

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38452/
-----------------------------------------------------------

(Updated 九月 29, 2015, 11:04 p.m.)


Review request for mesos and Ben Mahler.


Changes
-------

Add "Scoping" section according to Ben's comments


Bugs: MESOS-3450
    https://issues.apache.org/jira/browse/MESOS-3450


Repository: mesos


Description
-------

Updated C++ style guide for namespace usage


Diffs (updated)
-----

  docs/mesos-c++-style-guide.md 570ea6873ffc2cc8ec190ec3aa81986e3f3cbc95 

Diff: https://reviews.apache.org/r/38452/diff/


Testing
-------


Thanks,

Guangya Liu

Re: Review Request 38452: Updated C++ style guide for namespace usage

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38452/
-----------------------------------------------------------

(Updated 九月 24, 2015, 2:20 a.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-3450
    https://issues.apache.org/jira/browse/MESOS-3450


Repository: mesos


Description
-------

Updated C++ style guide for namespace usage


Diffs (updated)
-----

  docs/mesos-c++-style-guide.md 570ea6873ffc2cc8ec190ec3aa81986e3f3cbc95 

Diff: https://reviews.apache.org/r/38452/diff/


Testing
-------


Thanks,

Guangya Liu