You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/12/08 15:15:01 UTC

[GitHub] [accumulo] milleruntime commented on a change in pull request #2368: Create GenerateSplits utility

milleruntime commented on a change in pull request #2368:
URL: https://github.com/apache/accumulo/pull/2368#discussion_r764958481



##########
File path: core/src/main/java/org/apache/accumulo/core/file/rfile/GenerateSplits.java
##########
@@ -201,7 +201,9 @@ public void execute(String[] args) throws Exception {
       itemsSketch.update(row);
       iterator.next();
     }
-    return itemsSketch.getQuantiles(numSplits);
+    Text[] items = itemsSketch.getQuantiles(numSplits + 2);

Review comment:
       At that point all we can do is throw an error. I think checking the different outputs of the Datasketches API is a bit out of scope for this utility.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org