You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "keon94 (via GitHub)" <gi...@apache.org> on 2023/03/30 02:40:54 UTC

[GitHub] [incubator-devlake] keon94 opened a new pull request, #4815: [fix-4772]: Rapid Python progress update crashes Go DevLake server

keon94 opened a new pull request, #4815:
URL: https://github.com/apache/incubator-devlake/pull/4815

   ### Summary
   What does this PR do?
   
   ### Does this close any open issues?
   Closes #4772 
   
   ### Screenshots
   Include any relevant screenshots here.
   
   ### Other Information
   Any other information that is important to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] hezyin merged pull request #4815: [fix-4772]: Python progress update crashes Go DevLake server

Posted by "hezyin (via GitHub)" <gi...@apache.org>.
hezyin merged PR #4815:
URL: https://github.com/apache/incubator-devlake/pull/4815


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #4815: [fix-4772]: Python progress update crashes Go DevLake server

Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 commented on code in PR #4815:
URL: https://github.com/apache/incubator-devlake/pull/4815#discussion_r1153415963


##########
backend/core/utils/ipc.go:
##########
@@ -243,7 +243,9 @@ func scanOutputPipe(pipe io.ReadCloser, wg *sync.WaitGroup, onReceive func([]byt
 			src := scanner.Bytes()
 			data := make([]byte, len(src))
 			copy(data, src)
-			onReceive(data)
+			if onReceive != nil {

Review Comment:
   this missing nil check was the culprit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org