[GitHub] cassandra pull request #100: clean up

[aertoria <gi...@git.apache.org>]

GitHub user aertoria opened a pull request:

    https://github.com/apache/cassandra/pull/100

    clean up

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aertoria/cassandra trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cassandra/pull/100.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #100
    
----
commit 5e2df663dc9d6cd2d4fdedc98dc43a51fe00206d
Author: aertoria <ca...@gmail.com>
Date:   2017-03-20T07:01:38Z

    clean up

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cassandra issue #100: clean up

[jeffjirsa <gi...@git.apache.org>]

Github user jeffjirsa commented on the issue:

    https://github.com/apache/cassandra/pull/100
  
    This pull request is unlikely to be merged in it's current state. These changes seem scattered - there are a lot of asserts in the form that you changed, and a lot of comments in the form you changed, but you've only changed one of each, and they appear unrelated. It also has an unnecessary empty file (.toDelete), which we wouldn't want to merge.
    
    Finally, we really prefer JIRA tickets for non-trivial changes. I encourage you to close this pull request, as the project can not close it for you. Please see http://cassandra.apache.org/doc/latest/development/patches.html for details.  
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---