You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/07/16 06:05:57 UTC
[GitHub] [iotdb] BanDuWuZi commented on a diff in pull request #6686: [IOTDB-3840] deserialize RemoveDataNodePlan exception
BanDuWuZi commented on code in PR #6686:
URL: https://github.com/apache/iotdb/pull/6686#discussion_r922638208
##########
confignode/src/test/java/org/apache/iotdb/confignode/consensus/request/write/RemoveDataNodePlanTest.java:
##########
@@ -129,23 +129,44 @@ public void testTestHashCode() {
}
@Test
- public void testSerializeAndDeSerialized() throws IOException {
+ public void testNotUpdatePlanSerializeAndDeSerialize() {
+ try {
+ RemoveDataNodePlan deSerializeReq = runPlanSerializeAndDeSerialize(false);
+ Assert.assertEquals(req1, deSerializeReq);
+ } catch (IOException e) {
+ // do nothing
+ }
+ }
+
+ @Test
+ public void testUpdatePlanSerializeAndDeSerialize() {
+ try {
+ RemoveDataNodePlan deSerializeReq = runPlanSerializeAndDeSerialize(true);
+ Assert.assertEquals(req1, deSerializeReq);
+ } catch (IOException e) {
+ // do nothing
Review Comment:
fixed
##########
confignode/src/test/java/org/apache/iotdb/confignode/consensus/request/write/RemoveDataNodePlanTest.java:
##########
@@ -129,23 +129,44 @@ public void testTestHashCode() {
}
@Test
- public void testSerializeAndDeSerialized() throws IOException {
+ public void testNotUpdatePlanSerializeAndDeSerialize() {
+ try {
+ RemoveDataNodePlan deSerializeReq = runPlanSerializeAndDeSerialize(false);
+ Assert.assertEquals(req1, deSerializeReq);
+ } catch (IOException e) {
+ // do nothing
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org