You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cordova.apache.org by Andrew Grieve <ag...@chromium.org> on 2014/11/05 15:51:53 UTC

Re: Cordova: Comment on Deleting hidekeyboard and showkeyboard Events

Thanks Kevin. Forwarding to dev@ mailing list.

Seems like a candidate for 4.0.x branch? I think those that want to know
about the keyboard just use Ionic's keyboard plugin anyways, since that
works with newer Android versions.

On Tue, Nov 4, 2014 at 9:41 PM, Kevin Nuss <ke...@infoproc.com> wrote:

> I don’t have an account to add comments, so I’m being lazy and merely
> emailing you.
>
>
>
> In CB-6154 you suggested the removal of the ”hidekeyboard” and
> “showkeyboard” events from Cordova, which are in  cordova-android
> <https://github.com/apache/cordova-android/tree/c2cafb4b45fcbb307a113828dfc9f723f8a6433b>
> /framework
> <https://github.com/apache/cordova-android/tree/c2cafb4b45fcbb307a113828dfc9f723f8a6433b/framework>
> /src
> <https://github.com/apache/cordova-android/tree/c2cafb4b45fcbb307a113828dfc9f723f8a6433b/framework/src>
> /org
> <https://github.com/apache/cordova-android/tree/c2cafb4b45fcbb307a113828dfc9f723f8a6433b/framework/src/org>
> /apache
> <https://github.com/apache/cordova-android/tree/c2cafb4b45fcbb307a113828dfc9f723f8a6433b/framework/src/org/apache>
> /cordova
> <https://github.com/apache/cordova-android/tree/c2cafb4b45fcbb307a113828dfc9f723f8a6433b/framework/src/org/apache/cordova>/LinearLayoutSoftKeyboardDetect.java.
>
>
>
>
> If you need additional reasons to do so, this part of that code
>
>
>
>        else if (screenHeight == width)
>
>         {
>
>             int tmp_var = screenHeight;
>
>             screenHeight = screenWidth;
>
>             screenWidth = tmp_var;
>
>             LOG.v(TAG, "Orientation Change");
>
>         }
>
>
>
> sometimes erroneously causes a hide or show of the keyboard event though I
> am merely making an orientation change. The 48 pixel height of the status
> bar on a Samsung 10” tablet prevents the height from equaling the previous
> width after an orientation change.
>
>
>
> I don’t actually use the events, so I don’t care. But if the events are
> not deleted, perhaps someone can make the test a little better to handle
> the status bar difference.
>
> Kevin
>

Re: Cordova: Comment on Deleting hidekeyboard and showkeyboard Events

Posted by Andrew Grieve <ag...@chromium.org>.

Bumping this up again - Joe, still think this code is worth maintaining? Or
maybe just want to wait for 5.0 before removing it?

On Thu, Nov 6, 2014 at 12:44 PM, Kevin Nuss <ke...@infoproc.com> wrote:

> P.S.    LinearLayoutSoftKeyboardDetect.java uses the deprecated method
> “sendJavascript” in CordovaWebView.java. This ends up causing violations of
> Content-Security-Policy rules since I am using fairly strict ones that do
> not include ‘unsafe-eval’ . But events from backbutton and online/offline
> network status do not cause violations. I have not tested other plugins.
>
>
>
> Kevin Nuss
>
>
>
>
>
> *From:* mmocny@google.com [mailto:mmocny@google.com] *On Behalf Of *Michal
> Mocny
> *Sent:* Wednesday, November 05, 2014 10:50
> *To:* dev
> *Cc:* Andrew Grieve; Kevin Nuss
> *Subject:* Re: Cordova: Comment on Deleting hidekeyboard and showkeyboard
> Events
>
>
>
> Telling people to turn to [insert any project from the external community]
> for [a feature we used to support but is now openly supported elsewhere] --
> sounds amazing to me.
>
>
>
> What happened to the goal of "eventually cease to exist"?
>
>
>
> On Wed, Nov 5, 2014 at 11:26 AM, Joe Bowser <bo...@gmail.com> wrote:
>
> On Wed Nov 05 2014 at 8:21:03 AM Andrew Grieve <ag...@chromium.org>
> wrote:
>
> > Here's the ionic plugin:
> >
> https://github.com/driftyco/ionic-plugins-keyboard/blob/master/src/android/IonicKeyboard.java
> >
> > Uses a GlobalLayoutListener. the approach is described here:
> >
> http://stackoverflow.com/questions/2150078/how-to-check-visibility-of-software-keyboard-in-android
> >
> > Why leave the code in core if we don't have to? I think the majority of
> > apps wouldn't need these events (even if you do, you can listen for
> resize
> > events to do the same kind of detection)
> >
>
> I think this will break more things than it'll fix.  Does the Ionic plugin
> support all the versions of Android that we currently support? Are we
> really going to tell people to go to Ionic for a feature that we once
> supported? Even if this is technically better, this seems like it's a
> support nightmare.
>
>
>
> >
> > On Wed, Nov 5, 2014 at 11:05 AM, Joe Bowser <bo...@gmail.com> wrote:
> >
> >> I disagree. We recently fixed this when we went back to adjustResize
> from
> >> adjustPan, and we should just file a bug about the behaviour on the
> Samsung
> >> Tablet.
> >>
> >
> >
>
>
>

RE: Cordova: Comment on Deleting hidekeyboard and showkeyboard Events

Posted by Kevin Nuss <ke...@infoproc.com>.

P.S.    LinearLayoutSoftKeyboardDetect.java uses the deprecated method “sendJavascript” in CordovaWebView.java. This ends up causing violations of Content-Security-Policy rules since I am using fairly strict ones that do not include ‘unsafe-eval’ . But events from backbutton and online/offline network status do not cause violations. I have not tested other plugins.

Kevin Nuss

From: mmocny@google.com [mailto:mmocny@google.com] On Behalf Of Michal Mocny
Sent: Wednesday, November 05, 2014 10:50
To: dev
Cc: Andrew Grieve; Kevin Nuss
Subject: Re: Cordova: Comment on Deleting hidekeyboard and showkeyboard Events

Telling people to turn to [insert any project from the external community] for [a feature we used to support but is now openly supported elsewhere] -- sounds amazing to me.

What happened to the goal of "eventually cease to exist"?

On Wed, Nov 5, 2014 at 11:26 AM, Joe Bowser <bo...@gmail.com>> wrote:
On Wed Nov 05 2014 at 8:21:03 AM Andrew Grieve <ag...@chromium.org>> wrote:

> Here's the ionic plugin:
> https://github.com/driftyco/ionic-plugins-keyboard/blob/master/src/android/IonicKeyboard.java
>
> Uses a GlobalLayoutListener. the approach is described here:
> http://stackoverflow.com/questions/2150078/how-to-check-visibility-of-software-keyboard-in-android
>
> Why leave the code in core if we don't have to? I think the majority of
> apps wouldn't need these events (even if you do, you can listen for resize
> events to do the same kind of detection)
>

I think this will break more things than it'll fix.  Does the Ionic plugin
support all the versions of Android that we currently support? Are we
really going to tell people to go to Ionic for a feature that we once
supported? Even if this is technically better, this seems like it's a
support nightmare.

>
> On Wed, Nov 5, 2014 at 11:05 AM, Joe Bowser <bo...@gmail.com>> wrote:
>
>> I disagree. We recently fixed this when we went back to adjustResize from
>> adjustPan, and we should just file a bug about the behaviour on the Samsung
>> Tablet.
>>
>
>