You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2015/07/06 17:14:39 UTC
Re: Releasing 2.4
Hi All,
Thinking aloud:
It feels like the changes we are discussing in LOG4J-812 and LOG4J-1074 are
important and tricky to get right.
I wonder if the project would benefit from releasing the large set of
fixes, features, and updates we have now as 2.4 and then getting back to
working on LOG4J-812 and LOG4J-1074 for 2.5.
Thoughts?
Gary
On Sat, Jun 27, 2015 at 6:05 PM, Ralph Goers <ra...@dslextreme.com>
wrote:
> I’ve assigned Jiras I would like to work on to myself. There are probably
> more I’d like to do. That said, I probably won’t get to them before 2.4 is
> released.
>
> Ralph
>
> On Jun 27, 2015, at 3:44 PM, Gary Gregory <ga...@gmail.com> wrote:
>
> Devs,
>
> Curious: Do you all have set list of JIRAs you are addressing before 2.4?
>
> Gary
>
> On Tue, Jun 2, 2015 at 5:11 PM, Gary Gregory <ga...@gmail.com>
> wrote:
>
>> End of June sounds good.
>>
>> Gary
>>
>>
>> -------- Original message --------
>> From: Ralph Goers <ra...@dslextreme.com>
>> Date: 06/02/2015 15:09 (GMT-08:00)
>> To: Log4J Developers List <lo...@logging.apache.org>
>> Subject: Re: Releasing 2.4
>>
>> I would prefer to find some time to work on some issues instead of
>> spending that on doing a release. But no later than the end of June.
>>
>> Ralph
>>
>> On Jun 2, 2015, at 3:02 PM, Gary Gregory <ga...@gmail.com> wrote:
>>
>> It's been almost a month since 2.3 and we already have a nice little
>> batch of changes for 2.4.
>>
>> In particular, the 1.2 compatibility fixes to NDC pop() and peek() would
>> be good to push out ASAP.
>>
>> Thoughts?
>>
>> Gary
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Releasing 2.4
Posted by Remko Popma <re...@gmail.com>.
I believe we are in agreement for 1074 (pls let me know if not) and I just need to implement it. Doesn't seem very tricky, should be able to complete coming weekend. Would like to include it if possible.
I have a fix ready for 1030 (header at top of file only). If we can agree on that I can commit (tests all pass).
Sent from my iPhone
> On 2015/07/07, at 0:45, Ralph Goers <ra...@dslextreme.com> wrote:
>
> I had planned on committing the fix for 812 as soon as I got agreement from everyone that it is the right approach. The code is all done and all the unit tests pass.
>
> Ralph
>
>> On Jul 6, 2015, at 8:14 AM, Gary Gregory <ga...@gmail.com> wrote:
>>
>> Hi All,
>>
>> Thinking aloud:
>>
>> It feels like the changes we are discussing in LOG4J-812 and LOG4J-1074 are important and tricky to get right.
>>
>> I wonder if the project would benefit from releasing the large set of fixes, features, and updates we have now as 2.4 and then getting back to working on LOG4J-812 and LOG4J-1074 for 2.5.
>>
>> Thoughts?
>>
>> Gary
>>
>>> On Sat, Jun 27, 2015 at 6:05 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>>> I’ve assigned Jiras I would like to work on to myself. There are probably more I’d like to do. That said, I probably won’t get to them before 2.4 is released.
>>>
>>> Ralph
>>>
>>>> On Jun 27, 2015, at 3:44 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>
>>>> Devs,
>>>>
>>>> Curious: Do you all have set list of JIRAs you are addressing before 2.4?
>>>>
>>>> Gary
>>>>
>>>>> On Tue, Jun 2, 2015 at 5:11 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>> End of June sounds good.
>>>>>
>>>>> Gary
>>>>>
>>>>>
>>>>> -------- Original message --------
>>>>> From: Ralph Goers <ra...@dslextreme.com>
>>>>> Date: 06/02/2015 15:09 (GMT-08:00)
>>>>> To: Log4J Developers List <lo...@logging.apache.org>
>>>>> Subject: Re: Releasing 2.4
>>>>>
>>>>> I would prefer to find some time to work on some issues instead of spending that on doing a release. But no later than the end of June.
>>>>>
>>>>> Ralph
>>>>>
>>>>>> On Jun 2, 2015, at 3:02 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>
>>>>>> It's been almost a month since 2.3 and we already have a nice little batch of changes for 2.4.
>>>>>>
>>>>>> In particular, the 1.2 compatibility fixes to NDC pop() and peek() would be good to push out ASAP.
>>>>>>
>>>>>> Thoughts?
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>> --
>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>> JUnit in Action, Second Edition
>>>>>> Spring Batch in Action
>>>>>> Blog: http://garygregory.wordpress.com
>>>>>> Home: http://garygregory.com/
>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>>
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition
>>>> JUnit in Action, Second Edition
>>>> Spring Batch in Action
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> JUnit in Action, Second Edition
>> Spring Batch in Action
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
Re: Releasing 2.4
Posted by Gary Gregory <ga...@gmail.com>.
I think that's an NPE.
Gary
On Mon, Jul 6, 2015 at 2:53 PM, Remko Popma <re...@gmail.com> wrote:
> I forget: is it okay to use a switch if the var may be null?
>
> Sent from my iPhone
>
> On 2015/07/07, at 2:18, Gary Gregory <ga...@gmail.com> wrote:
>
> Tangent: In the DatePatternConverter ctor, you could also use a String
> switch instead of if/else's.
>
> Gary
>
> On Mon, Jul 6, 2015 at 10:16 AM, Gary Gregory <ga...@gmail.com>
> wrote:
>
>> Ah, OK, I was going to ask about that because I see this:
>>
>> if (timestamp != currentTime.timestamp) {
>>
>> }
>>
>> So I'll wait... and get back to work$ ;-)
>>
>> Gary
>>
>> On Mon, Jul 6, 2015 at 10:15 AM, Ralph Goers <ra...@dslextreme.com>
>> wrote:
>>
>>> OK - but I haven’t updated the patch to resolve the error Remko found.
>>> I will do that when I get a chance today.
>>>
>>> Ralph
>>>
>>> On Jul 6, 2015, at 10:05 AM, Gary Gregory <ga...@gmail.com>
>>> wrote:
>>>
>>> I'll review the patch ASAP...
>>>
>>> Gary
>>>
>>> On Mon, Jul 6, 2015 at 8:45 AM, Ralph Goers <ra...@dslextreme.com>
>>> wrote:
>>>
>>>> I had planned on committing the fix for 812 as soon as I got agreement
>>>> from everyone that it is the right approach. The code is all done and all
>>>> the unit tests pass.
>>>>
>>>> Ralph
>>>>
>>>> On Jul 6, 2015, at 8:14 AM, Gary Gregory <ga...@gmail.com>
>>>> wrote:
>>>>
>>>> Hi All,
>>>>
>>>> Thinking aloud:
>>>>
>>>> It feels like the changes we are discussing in LOG4J-812 and LOG4J-1074
>>>> are important and tricky to get right.
>>>>
>>>> I wonder if the project would benefit from releasing the large set of
>>>> fixes, features, and updates we have now as 2.4 and then getting back to
>>>> working on LOG4J-812 and LOG4J-1074 for 2.5.
>>>>
>>>> Thoughts?
>>>>
>>>> Gary
>>>>
>>>> On Sat, Jun 27, 2015 at 6:05 PM, Ralph Goers <
>>>> ralph.goers@dslextreme.com> wrote:
>>>>
>>>>> I’ve assigned Jiras I would like to work on to myself. There are
>>>>> probably more I’d like to do. That said, I probably won’t get to them
>>>>> before 2.4 is released.
>>>>>
>>>>> Ralph
>>>>>
>>>>> On Jun 27, 2015, at 3:44 PM, Gary Gregory <ga...@gmail.com>
>>>>> wrote:
>>>>>
>>>>> Devs,
>>>>>
>>>>> Curious: Do you all have set list of JIRAs you are addressing before
>>>>> 2.4?
>>>>>
>>>>> Gary
>>>>>
>>>>> On Tue, Jun 2, 2015 at 5:11 PM, Gary Gregory <ga...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> End of June sounds good.
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>>
>>>>>> -------- Original message --------
>>>>>> From: Ralph Goers <ra...@dslextreme.com>
>>>>>> Date: 06/02/2015 15:09 (GMT-08:00)
>>>>>> To: Log4J Developers List <lo...@logging.apache.org>
>>>>>> Subject: Re: Releasing 2.4
>>>>>>
>>>>>> I would prefer to find some time to work on some issues instead of
>>>>>> spending that on doing a release. But no later than the end of June.
>>>>>>
>>>>>> Ralph
>>>>>>
>>>>>> On Jun 2, 2015, at 3:02 PM, Gary Gregory <ga...@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>> It's been almost a month since 2.3 and we already have a nice little
>>>>>> batch of changes for 2.4.
>>>>>>
>>>>>> In particular, the 1.2 compatibility fixes to NDC pop() and peek()
>>>>>> would be good to push out ASAP.
>>>>>>
>>>>>> Thoughts?
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>> --
>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>> <http://www.manning.com/bauer3/>
>>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>>> Blog: http://garygregory.wordpress.com
>>>>>> Home: http://garygregory.com/
>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>> Java Persistence with Hibernate, Second Edition
>>>>> <http://www.manning.com/bauer3/>
>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>> Blog: http://garygregory.wordpress.com
>>>>> Home: http://garygregory.com/
>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition
>>>> <http://www.manning.com/bauer3/>
>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>>
>>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Releasing 2.4
Posted by Remko Popma <re...@gmail.com>.
I forget: is it okay to use a switch if the var may be null?
Sent from my iPhone
> On 2015/07/07, at 2:18, Gary Gregory <ga...@gmail.com> wrote:
>
> Tangent: In the DatePatternConverter ctor, you could also use a String switch instead of if/else's.
>
> Gary
>
>> On Mon, Jul 6, 2015 at 10:16 AM, Gary Gregory <ga...@gmail.com> wrote:
>> Ah, OK, I was going to ask about that because I see this:
>>
>> if (timestamp != currentTime.timestamp) {
>>
>> }
>>
>> So I'll wait... and get back to work$ ;-)
>>
>> Gary
>>
>>> On Mon, Jul 6, 2015 at 10:15 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>> OK - but I haven’t updated the patch to resolve the error Remko found. I will do that when I get a chance today.
>>>
>>> Ralph
>>>
>>>> On Jul 6, 2015, at 10:05 AM, Gary Gregory <ga...@gmail.com> wrote:
>>>>
>>>> I'll review the patch ASAP...
>>>>
>>>> Gary
>>>>
>>>>> On Mon, Jul 6, 2015 at 8:45 AM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>> I had planned on committing the fix for 812 as soon as I got agreement from everyone that it is the right approach. The code is all done and all the unit tests pass.
>>>>>
>>>>> Ralph
>>>>>
>>>>>> On Jul 6, 2015, at 8:14 AM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>
>>>>>> Hi All,
>>>>>>
>>>>>> Thinking aloud:
>>>>>>
>>>>>> It feels like the changes we are discussing in LOG4J-812 and LOG4J-1074 are important and tricky to get right.
>>>>>>
>>>>>> I wonder if the project would benefit from releasing the large set of fixes, features, and updates we have now as 2.4 and then getting back to working on LOG4J-812 and LOG4J-1074 for 2.5.
>>>>>>
>>>>>> Thoughts?
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>>> On Sat, Jun 27, 2015 at 6:05 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>>> I’ve assigned Jiras I would like to work on to myself. There are probably more I’d like to do. That said, I probably won’t get to them before 2.4 is released.
>>>>>>>
>>>>>>> Ralph
>>>>>>>
>>>>>>>> On Jun 27, 2015, at 3:44 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>
>>>>>>>> Devs,
>>>>>>>>
>>>>>>>> Curious: Do you all have set list of JIRAs you are addressing before 2.4?
>>>>>>>>
>>>>>>>> Gary
>>>>>>>>
>>>>>>>>> On Tue, Jun 2, 2015 at 5:11 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>> End of June sounds good.
>>>>>>>>>
>>>>>>>>> Gary
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> -------- Original message --------
>>>>>>>>> From: Ralph Goers <ra...@dslextreme.com>
>>>>>>>>> Date: 06/02/2015 15:09 (GMT-08:00)
>>>>>>>>> To: Log4J Developers List <lo...@logging.apache.org>
>>>>>>>>> Subject: Re: Releasing 2.4
>>>>>>>>>
>>>>>>>>> I would prefer to find some time to work on some issues instead of spending that on doing a release. But no later than the end of June.
>>>>>>>>>
>>>>>>>>> Ralph
>>>>>>>>>
>>>>>>>>>> On Jun 2, 2015, at 3:02 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>>>>>
>>>>>>>>>> It's been almost a month since 2.3 and we already have a nice little batch of changes for 2.4.
>>>>>>>>>>
>>>>>>>>>> In particular, the 1.2 compatibility fixes to NDC pop() and peek() would be good to push out ASAP.
>>>>>>>>>>
>>>>>>>>>> Thoughts?
>>>>>>>>>>
>>>>>>>>>> Gary
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>>>>> JUnit in Action, Second Edition
>>>>>>>>>> Spring Batch in Action
>>>>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>>>>> Home: http://garygregory.com/
>>>>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>>> JUnit in Action, Second Edition
>>>>>>>> Spring Batch in Action
>>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>>> Home: http://garygregory.com/
>>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>> JUnit in Action, Second Edition
>>>>>> Spring Batch in Action
>>>>>> Blog: http://garygregory.wordpress.com
>>>>>> Home: http://garygregory.com/
>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>>
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition
>>>> JUnit in Action, Second Edition
>>>> Spring Batch in Action
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> JUnit in Action, Second Edition
>> Spring Batch in Action
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
Re: Releasing 2.4
Posted by Gary Gregory <ga...@gmail.com>.
Tangent: In the DatePatternConverter ctor, you could also use a String
switch instead of if/else's.
Gary
On Mon, Jul 6, 2015 at 10:16 AM, Gary Gregory <ga...@gmail.com>
wrote:
> Ah, OK, I was going to ask about that because I see this:
>
> if (timestamp != currentTime.timestamp) {
>
> }
>
> So I'll wait... and get back to work$ ;-)
>
> Gary
>
> On Mon, Jul 6, 2015 at 10:15 AM, Ralph Goers <ra...@dslextreme.com>
> wrote:
>
>> OK - but I haven’t updated the patch to resolve the error Remko found. I
>> will do that when I get a chance today.
>>
>> Ralph
>>
>> On Jul 6, 2015, at 10:05 AM, Gary Gregory <ga...@gmail.com> wrote:
>>
>> I'll review the patch ASAP...
>>
>> Gary
>>
>> On Mon, Jul 6, 2015 at 8:45 AM, Ralph Goers <ra...@dslextreme.com>
>> wrote:
>>
>>> I had planned on committing the fix for 812 as soon as I got agreement
>>> from everyone that it is the right approach. The code is all done and all
>>> the unit tests pass.
>>>
>>> Ralph
>>>
>>> On Jul 6, 2015, at 8:14 AM, Gary Gregory <ga...@gmail.com> wrote:
>>>
>>> Hi All,
>>>
>>> Thinking aloud:
>>>
>>> It feels like the changes we are discussing in LOG4J-812 and LOG4J-1074
>>> are important and tricky to get right.
>>>
>>> I wonder if the project would benefit from releasing the large set of
>>> fixes, features, and updates we have now as 2.4 and then getting back to
>>> working on LOG4J-812 and LOG4J-1074 for 2.5.
>>>
>>> Thoughts?
>>>
>>> Gary
>>>
>>> On Sat, Jun 27, 2015 at 6:05 PM, Ralph Goers <ralph.goers@dslextreme.com
>>> > wrote:
>>>
>>>> I’ve assigned Jiras I would like to work on to myself. There are
>>>> probably more I’d like to do. That said, I probably won’t get to them
>>>> before 2.4 is released.
>>>>
>>>> Ralph
>>>>
>>>> On Jun 27, 2015, at 3:44 PM, Gary Gregory <ga...@gmail.com>
>>>> wrote:
>>>>
>>>> Devs,
>>>>
>>>> Curious: Do you all have set list of JIRAs you are addressing before
>>>> 2.4?
>>>>
>>>> Gary
>>>>
>>>> On Tue, Jun 2, 2015 at 5:11 PM, Gary Gregory <ga...@gmail.com>
>>>> wrote:
>>>>
>>>>> End of June sounds good.
>>>>>
>>>>> Gary
>>>>>
>>>>>
>>>>> -------- Original message --------
>>>>> From: Ralph Goers <ra...@dslextreme.com>
>>>>> Date: 06/02/2015 15:09 (GMT-08:00)
>>>>> To: Log4J Developers List <lo...@logging.apache.org>
>>>>> Subject: Re: Releasing 2.4
>>>>>
>>>>> I would prefer to find some time to work on some issues instead of
>>>>> spending that on doing a release. But no later than the end of June.
>>>>>
>>>>> Ralph
>>>>>
>>>>> On Jun 2, 2015, at 3:02 PM, Gary Gregory <ga...@gmail.com>
>>>>> wrote:
>>>>>
>>>>> It's been almost a month since 2.3 and we already have a nice little
>>>>> batch of changes for 2.4.
>>>>>
>>>>> In particular, the 1.2 compatibility fixes to NDC pop() and peek()
>>>>> would be good to push out ASAP.
>>>>>
>>>>> Thoughts?
>>>>>
>>>>> Gary
>>>>>
>>>>> --
>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>> Java Persistence with Hibernate, Second Edition
>>>>> <http://www.manning.com/bauer3/>
>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>> Blog: http://garygregory.wordpress.com
>>>>> Home: http://garygregory.com/
>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition
>>>> <http://www.manning.com/bauer3/>
>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>>
>>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Releasing 2.4
Posted by Gary Gregory <ga...@gmail.com>.
Ah, OK, I was going to ask about that because I see this:
if (timestamp != currentTime.timestamp) {
}
So I'll wait... and get back to work$ ;-)
Gary
On Mon, Jul 6, 2015 at 10:15 AM, Ralph Goers <ra...@dslextreme.com>
wrote:
> OK - but I haven’t updated the patch to resolve the error Remko found. I
> will do that when I get a chance today.
>
> Ralph
>
> On Jul 6, 2015, at 10:05 AM, Gary Gregory <ga...@gmail.com> wrote:
>
> I'll review the patch ASAP...
>
> Gary
>
> On Mon, Jul 6, 2015 at 8:45 AM, Ralph Goers <ra...@dslextreme.com>
> wrote:
>
>> I had planned on committing the fix for 812 as soon as I got agreement
>> from everyone that it is the right approach. The code is all done and all
>> the unit tests pass.
>>
>> Ralph
>>
>> On Jul 6, 2015, at 8:14 AM, Gary Gregory <ga...@gmail.com> wrote:
>>
>> Hi All,
>>
>> Thinking aloud:
>>
>> It feels like the changes we are discussing in LOG4J-812 and LOG4J-1074
>> are important and tricky to get right.
>>
>> I wonder if the project would benefit from releasing the large set of
>> fixes, features, and updates we have now as 2.4 and then getting back to
>> working on LOG4J-812 and LOG4J-1074 for 2.5.
>>
>> Thoughts?
>>
>> Gary
>>
>> On Sat, Jun 27, 2015 at 6:05 PM, Ralph Goers <ra...@dslextreme.com>
>> wrote:
>>
>>> I’ve assigned Jiras I would like to work on to myself. There are
>>> probably more I’d like to do. That said, I probably won’t get to them
>>> before 2.4 is released.
>>>
>>> Ralph
>>>
>>> On Jun 27, 2015, at 3:44 PM, Gary Gregory <ga...@gmail.com>
>>> wrote:
>>>
>>> Devs,
>>>
>>> Curious: Do you all have set list of JIRAs you are addressing before 2.4?
>>>
>>> Gary
>>>
>>> On Tue, Jun 2, 2015 at 5:11 PM, Gary Gregory <ga...@gmail.com>
>>> wrote:
>>>
>>>> End of June sounds good.
>>>>
>>>> Gary
>>>>
>>>>
>>>> -------- Original message --------
>>>> From: Ralph Goers <ra...@dslextreme.com>
>>>> Date: 06/02/2015 15:09 (GMT-08:00)
>>>> To: Log4J Developers List <lo...@logging.apache.org>
>>>> Subject: Re: Releasing 2.4
>>>>
>>>> I would prefer to find some time to work on some issues instead of
>>>> spending that on doing a release. But no later than the end of June.
>>>>
>>>> Ralph
>>>>
>>>> On Jun 2, 2015, at 3:02 PM, Gary Gregory <ga...@gmail.com>
>>>> wrote:
>>>>
>>>> It's been almost a month since 2.3 and we already have a nice little
>>>> batch of changes for 2.4.
>>>>
>>>> In particular, the 1.2 compatibility fixes to NDC pop() and peek()
>>>> would be good to push out ASAP.
>>>>
>>>> Thoughts?
>>>>
>>>> Gary
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition
>>>> <http://www.manning.com/bauer3/>
>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>>
>>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Releasing 2.4
Posted by Ralph Goers <ra...@dslextreme.com>.
OK - but I haven’t updated the patch to resolve the error Remko found. I will do that when I get a chance today.
Ralph
> On Jul 6, 2015, at 10:05 AM, Gary Gregory <ga...@gmail.com> wrote:
>
> I'll review the patch ASAP...
>
> Gary
>
> On Mon, Jul 6, 2015 at 8:45 AM, Ralph Goers <ralph.goers@dslextreme.com <ma...@dslextreme.com>> wrote:
> I had planned on committing the fix for 812 as soon as I got agreement from everyone that it is the right approach. The code is all done and all the unit tests pass.
>
> Ralph
>
>> On Jul 6, 2015, at 8:14 AM, Gary Gregory <garydgregory@gmail.com <ma...@gmail.com>> wrote:
>>
>> Hi All,
>>
>> Thinking aloud:
>>
>> It feels like the changes we are discussing in LOG4J-812 and LOG4J-1074 are important and tricky to get right.
>>
>> I wonder if the project would benefit from releasing the large set of fixes, features, and updates we have now as 2.4 and then getting back to working on LOG4J-812 and LOG4J-1074 for 2.5.
>>
>> Thoughts?
>>
>> Gary
>>
>> On Sat, Jun 27, 2015 at 6:05 PM, Ralph Goers <ralph.goers@dslextreme.com <ma...@dslextreme.com>> wrote:
>> I’ve assigned Jiras I would like to work on to myself. There are probably more I’d like to do. That said, I probably won’t get to them before 2.4 is released.
>>
>> Ralph
>>
>>> On Jun 27, 2015, at 3:44 PM, Gary Gregory <garydgregory@gmail.com <ma...@gmail.com>> wrote:
>>>
>>> Devs,
>>>
>>> Curious: Do you all have set list of JIRAs you are addressing before 2.4?
>>>
>>> Gary
>>>
>>> On Tue, Jun 2, 2015 at 5:11 PM, Gary Gregory <garydgregory@gmail.com <ma...@gmail.com>> wrote:
>>> End of June sounds good.
>>>
>>> Gary
>>>
>>>
>>> -------- Original message --------
>>> From: Ralph Goers <ralph.goers@dslextreme.com <ma...@dslextreme.com>>
>>> Date: 06/02/2015 15:09 (GMT-08:00)
>>> To: Log4J Developers List <log4j-dev@logging.apache.org <ma...@logging.apache.org>>
>>> Subject: Re: Releasing 2.4
>>>
>>> I would prefer to find some time to work on some issues instead of spending that on doing a release. But no later than the end of June.
>>>
>>> Ralph
>>>
>>>> On Jun 2, 2015, at 3:02 PM, Gary Gregory <garydgregory@gmail.com <ma...@gmail.com>> wrote:
>>>>
>>>> It's been almost a month since 2.3 and we already have a nice little batch of changes for 2.4.
>>>>
>>>> In particular, the 1.2 compatibility fixes to NDC pop() and peek() would be good to push out ASAP.
>>>>
>>>> Thoughts?
>>>>
>>>> Gary
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com <ma...@gmail.com> | ggregory@apache.org <ma...@apache.org>
>>>> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/>
>>>> Home: http://garygregory.com/ <http://garygregory.com/>
>>>> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
>>>
>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com <ma...@gmail.com> | ggregory@apache.org <ma...@apache.org>
>>> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/>
>>> Home: http://garygregory.com/ <http://garygregory.com/>
>>> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com <ma...@gmail.com> | ggregory@apache.org <ma...@apache.org>
>> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/>
>> Home: http://garygregory.com/ <http://garygregory.com/>
>> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
>
>
>
> --
> E-Mail: garydgregory@gmail.com <ma...@gmail.com> | ggregory@apache.org <ma...@apache.org>
> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/>
> Home: http://garygregory.com/ <http://garygregory.com/>
> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
Re: Releasing 2.4
Posted by Gary Gregory <ga...@gmail.com>.
I'll review the patch ASAP...
Gary
On Mon, Jul 6, 2015 at 8:45 AM, Ralph Goers <ra...@dslextreme.com>
wrote:
> I had planned on committing the fix for 812 as soon as I got agreement
> from everyone that it is the right approach. The code is all done and all
> the unit tests pass.
>
> Ralph
>
> On Jul 6, 2015, at 8:14 AM, Gary Gregory <ga...@gmail.com> wrote:
>
> Hi All,
>
> Thinking aloud:
>
> It feels like the changes we are discussing in LOG4J-812 and LOG4J-1074
> are important and tricky to get right.
>
> I wonder if the project would benefit from releasing the large set of
> fixes, features, and updates we have now as 2.4 and then getting back to
> working on LOG4J-812 and LOG4J-1074 for 2.5.
>
> Thoughts?
>
> Gary
>
> On Sat, Jun 27, 2015 at 6:05 PM, Ralph Goers <ra...@dslextreme.com>
> wrote:
>
>> I’ve assigned Jiras I would like to work on to myself. There are probably
>> more I’d like to do. That said, I probably won’t get to them before 2.4 is
>> released.
>>
>> Ralph
>>
>> On Jun 27, 2015, at 3:44 PM, Gary Gregory <ga...@gmail.com> wrote:
>>
>> Devs,
>>
>> Curious: Do you all have set list of JIRAs you are addressing before 2.4?
>>
>> Gary
>>
>> On Tue, Jun 2, 2015 at 5:11 PM, Gary Gregory <ga...@gmail.com>
>> wrote:
>>
>>> End of June sounds good.
>>>
>>> Gary
>>>
>>>
>>> -------- Original message --------
>>> From: Ralph Goers <ra...@dslextreme.com>
>>> Date: 06/02/2015 15:09 (GMT-08:00)
>>> To: Log4J Developers List <lo...@logging.apache.org>
>>> Subject: Re: Releasing 2.4
>>>
>>> I would prefer to find some time to work on some issues instead of
>>> spending that on doing a release. But no later than the end of June.
>>>
>>> Ralph
>>>
>>> On Jun 2, 2015, at 3:02 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>
>>> It's been almost a month since 2.3 and we already have a nice little
>>> batch of changes for 2.4.
>>>
>>> In particular, the 1.2 compatibility fixes to NDC pop() and peek() would
>>> be good to push out ASAP.
>>>
>>> Thoughts?
>>>
>>> Gary
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>>
>>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Releasing 2.4
Posted by Ralph Goers <ra...@dslextreme.com>.
I had planned on committing the fix for 812 as soon as I got agreement from everyone that it is the right approach. The code is all done and all the unit tests pass.
Ralph
> On Jul 6, 2015, at 8:14 AM, Gary Gregory <ga...@gmail.com> wrote:
>
> Hi All,
>
> Thinking aloud:
>
> It feels like the changes we are discussing in LOG4J-812 and LOG4J-1074 are important and tricky to get right.
>
> I wonder if the project would benefit from releasing the large set of fixes, features, and updates we have now as 2.4 and then getting back to working on LOG4J-812 and LOG4J-1074 for 2.5.
>
> Thoughts?
>
> Gary
>
> On Sat, Jun 27, 2015 at 6:05 PM, Ralph Goers <ralph.goers@dslextreme.com <ma...@dslextreme.com>> wrote:
> I’ve assigned Jiras I would like to work on to myself. There are probably more I’d like to do. That said, I probably won’t get to them before 2.4 is released.
>
> Ralph
>
>> On Jun 27, 2015, at 3:44 PM, Gary Gregory <garydgregory@gmail.com <ma...@gmail.com>> wrote:
>>
>> Devs,
>>
>> Curious: Do you all have set list of JIRAs you are addressing before 2.4?
>>
>> Gary
>>
>> On Tue, Jun 2, 2015 at 5:11 PM, Gary Gregory <garydgregory@gmail.com <ma...@gmail.com>> wrote:
>> End of June sounds good.
>>
>> Gary
>>
>>
>> -------- Original message --------
>> From: Ralph Goers <ralph.goers@dslextreme.com <ma...@dslextreme.com>>
>> Date: 06/02/2015 15:09 (GMT-08:00)
>> To: Log4J Developers List <log4j-dev@logging.apache.org <ma...@logging.apache.org>>
>> Subject: Re: Releasing 2.4
>>
>> I would prefer to find some time to work on some issues instead of spending that on doing a release. But no later than the end of June.
>>
>> Ralph
>>
>>> On Jun 2, 2015, at 3:02 PM, Gary Gregory <garydgregory@gmail.com <ma...@gmail.com>> wrote:
>>>
>>> It's been almost a month since 2.3 and we already have a nice little batch of changes for 2.4.
>>>
>>> In particular, the 1.2 compatibility fixes to NDC pop() and peek() would be good to push out ASAP.
>>>
>>> Thoughts?
>>>
>>> Gary
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com <ma...@gmail.com> | ggregory@apache.org <ma...@apache.org>
>>> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/>
>>> Home: http://garygregory.com/ <http://garygregory.com/>
>>> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com <ma...@gmail.com> | ggregory@apache.org <ma...@apache.org>
>> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/>
>> Home: http://garygregory.com/ <http://garygregory.com/>
>> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>
>
>
>
> --
> E-Mail: garydgregory@gmail.com <ma...@gmail.com> | ggregory@apache.org <ma...@apache.org>
> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/>
> Home: http://garygregory.com/ <http://garygregory.com/>
> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>