You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pivot.apache.org by "Greg Brown (JIRA)" <ji...@apache.org> on 2009/08/05 15:30:15 UTC

[jira] Created: (PIVOT-206) Review framework classes for serializability

Review framework classes for serializability
--------------------------------------------

                 Key: PIVOT-206
                 URL: https://issues.apache.org/jira/browse/PIVOT-206
             Project: Pivot
          Issue Type: Task
    Affects Versions: 1.3
            Reporter: Greg Brown
            Assignee: Greg Brown
            Priority: Minor
             Fix For: 1.3.1


Ensure that all classes (collections, comparators, etc.) that should be serializable implement the Serializable interface.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Created: (PIVOT-206) Review framework classes for serializability

Posted by Sandro Martini <sa...@gmail.com>.

Hi Greg,
many thanks to Findbugs ...

Comparator doesn't implement Serializable
Folder.java:43 org.apache.pivot.io.Folder$FileNameComparator
implements Comparator but not Serializable
TreeView.java:331 org.apache.pivot.wtk.TreeView$PathComparator
implements Comparator but not Serializable
TreeNodeComparator.java:1
org.apache.pivot.tutorials.TreeNodeComparator implements Comparator
but not Serializable
TableView.java:484 org.apache.pivot.wtk.TableView$RowComparator
implements Comparator but not Serializable
FileList.java:32 org.apache.pivot.io.FileList$FilePathComparator
implements Comparator but not Serializable
Element.java:72 org.apache.pivot.wtk.text.Element$NodeOffsetComparator
implements Comparator but not Serializable

Tell me if i have to do the work.

Bye

Re: [jira] Created: (PIVOT-206) Review framework classes for serializability

Posted by Greg Brown <gk...@mac.com>.

Sure. I think all of our collection classes should be serializable, and, at the moment, some are probably not. Not all of our comparators necessarily need to be serializable, but let's try to identify the ones that do. Can you send out a list of the classes you think should be serializable?

On Wednesday, August 05, 2009, at 10:01AM, "Sandro Martini" <sa...@gmail.com> wrote:
>Hi to all,
>tell me if i can help on this, or assign to me directly if desired ...
>
>Bye
>
>

Re: [jira] Created: (PIVOT-206) Review framework classes for serializability

Posted by Sandro Martini <sa...@gmail.com>.

Hi to all,
tell me if i can help on this, or assign to me directly if desired ...

Bye

[jira] Updated: (PIVOT-206) Review framework classes for serializability

Posted by "Todd Volkert (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/PIVOT-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Volkert updated PIVOT-206:
-------------------------------

    Issue Type: Improvement  (was: Task)

> Review framework classes for serializability
> --------------------------------------------
>
>                 Key: PIVOT-206
>                 URL: https://issues.apache.org/jira/browse/PIVOT-206
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 1.3
>            Reporter: Greg Brown
>            Assignee: Greg Brown
>            Priority: Minor
>             Fix For: 1.3
>
>
> Ensure that all classes (collections, comparators, etc.) that should be serializable implement the Serializable interface.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (PIVOT-206) Review framework classes for serializability

Posted by "Greg Brown (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/PIVOT-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Greg Brown resolved PIVOT-206.
------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.3.1)
                   1.3

> Review framework classes for serializability
> --------------------------------------------
>
>                 Key: PIVOT-206
>                 URL: https://issues.apache.org/jira/browse/PIVOT-206
>             Project: Pivot
>          Issue Type: Task
>    Affects Versions: 1.3
>            Reporter: Greg Brown
>            Assignee: Greg Brown
>            Priority: Minor
>             Fix For: 1.3
>
>
> Ensure that all classes (collections, comparators, etc.) that should be serializable implement the Serializable interface.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.