You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/06/24 06:29:26 UTC

[GitHub] [incubator-pegasus] foreverneverer opened a new pull request, #1017: fix: add thirdparty for centos6 build env

foreverneverer opened a new pull request, #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017

   # Ref-Issue
   https://github.com/apache/incubator-pegasus/issues/903
   
   https://github.com/XiaoMi/rdsn/pull/979
   
   # Change
   https://github.com/XiaoMi/rdsn/pull/979 remove `krb5` and `cyrus-sasl`,  but it's necessary for `CentOS6`. this pr revert it and it must put before `zookeeper` in CMakeList.txt
   
   In pack_server.sh, it also need be update


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r907002355


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   centos6 has stopped supporting and I haven't find the open software yum-repo.  I have build centos6-docker-env in our company internal



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r907964547


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   I think if one package has compatibility problem in different env, the best solution is specify unified version(if we can find the version) in thirdparty, but not use different version in different env.
   
   So I think the two package actually should be included in thirdparty though in centos7, unless one day we no longer support centos6



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r910784178


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   > > Have you tried https://www.getpagespeed.com/server-setup/how-to-fix-yum-after-centos-6-went-eol? I've tested that the two libs can be installed.
   > > But I think there must be some other problems to build on centos6, it's better to create a centos6 Dockerfile to resolve all the problems.
   > 
   > Great, I will try it
   
   I have test and the repo can be used



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r907964910


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   > Have you tried https://www.getpagespeed.com/server-setup/how-to-fix-yum-after-centos-6-went-eol? I've tested that the two libs can be installed.
   > But I think there must be some other problems to build on centos6, it's better to create a centos6 Dockerfile to resolve all the problems.
   
   Great, I will try it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r907987947


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   Yeah, I actually don't want support the old version, but our company need it, and maybe need some time to upgrade the centos7.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] foreverneverer closed pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
foreverneverer closed pull request #1017: build(thirdparty): add thirdparty for centos6 build env 
URL: https://github.com/apache/incubator-pegasus/pull/1017


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r907964547


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   > And, for the non-centos6 platforms, we'd better skip build the two packages since we have installed the packages.
   I think if one package has compatibility problem in different env, the best solution is specify unified version(if we can find the version) in thirdparty, but not use different version in different env.
   
   So I think the two package actually should be included in thirdparty though in centos7, unless one day we no longer support centos6



##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   > And, for the non-centos6 platforms, we'd better skip build the two packages since we have installed the packages.
   
   I think if one package has compatibility problem in different env, the best solution is specify unified version(if we can find the version) in thirdparty, but not use different version in different env.
   
   So I think the two package actually should be included in thirdparty though in centos7, unless one day we no longer support centos6



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r907215358


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   Have you tried https://www.getpagespeed.com/server-setup/how-to-fix-yum-after-centos-6-went-eol? I've tested that the two libs can be installed.
   But I think there must be some other problems to build on centos6, it's better to create a centos6 Dockerfile to resolve all the problems.
   And, for the non-centos6 platforms, we'd better skip build the two packages since we have installed the packages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r907986353


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   > I think if one package has compatibility problem in different env, the best solution is specify unified version(if we can find the version) in thirdparty, but not use different version in different env.
   
   Agree. But only limit to the platforms we plan to support, centos 6 is EOL on 2020-12, I don't think it's worthy to support it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r907215358


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   Have you tried https://www.getpagespeed.com/server-setup/how-to-fix-yum-after-centos-6-went-eol? I've test that the two libs can be installed.
   But I think there must be some other problems to build on centos6, it's better to create a centos6 Dockerfile to resolve all the problems.
   And, for the non-centos6 platforms, we'd better skip build the two packages since we have installed the packages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r910784178


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   > > Have you tried https://www.getpagespeed.com/server-setup/how-to-fix-yum-after-centos-6-went-eol? I've tested that the two libs can be installed.
   > > But I think there must be some other problems to build on centos6, it's better to create a centos6 Dockerfile to resolve all the problems.
   > 
   > Great, I will try it
   
   I have tested and the repo can be used:
   https://hub.docker.com/layers/pegasus/apache/pegasus/build-env-centos6/images/sha256-a637b5bfdb4095b616e4f56ab96abbfce94fc2677eb464aeb46a5f35fc7bfe97?context=explore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r905900152


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5
+        URL ${OSS_URL_PREFIX}/krb5-1.16.1.tar.gz

Review Comment:
   @GehaFearless help to upload these two packages to OSS, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r907003084


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   > Can't the two libs be installed directly on centos6?
   
   the version is too old to be compatibility with `zookeeper`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r907964910


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   > Have you tried https://www.getpagespeed.com/server-setup/how-to-fix-yum-after-centos-6-went-eol? I've tested that the two libs can be installed.
   > But I think there must be some other problems to build on centos6, it's better to create a centos6 Dockerfile to resolve all the problems.
   > And, for the non-centos6 platforms, we'd better skip build the two packages since we have installed the packages.
   
   Great, I will try it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r906941386


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   Can't the two libs be installed directly on centos6?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r907986353


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   > I think if one package has compatibility problem in different env, the best solution is specify unified version(if we can find the version) in thirdparty, but not use different version in different env.
   
   Agree. But only limit to the platforms we plan to support, centos 6 is EOL in 2020-12, I don't think it's worthy to support it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r910784178


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   > > Have you tried https://www.getpagespeed.com/server-setup/how-to-fix-yum-after-centos-6-went-eol? I've tested that the two libs can be installed.
   > > But I think there must be some other problems to build on centos6, it's better to create a centos6 Dockerfile to resolve all the problems.
   > 
   > Great, I will try it
   
   I have test and the repo can be used:
   https://hub.docker.com/layers/pegasus/apache/pegasus/build-env-centos6/images/sha256-a637b5bfdb4095b616e4f56ab96abbfce94fc2677eb464aeb46a5f35fc7bfe97?context=explore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r906945055


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   Why not add centos6 Dockerfile if you insist to support centos6?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
foreverneverer commented on code in PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017#discussion_r910784178


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -156,6 +156,33 @@ ExternalProject_Add(thrift
         DEPENDS boost
         )
 
+# kerberos
+ExternalProject_Add(krb5

Review Comment:
   > > Have you tried https://www.getpagespeed.com/server-setup/how-to-fix-yum-after-centos-6-went-eol? I've tested that the two libs can be installed.
   > > But I think there must be some other problems to build on centos6, it's better to create a centos6 Dockerfile to resolve all the problems.
   > 
   > Great, I will try it
   
   I have tested and the repo can be used:
   https://hub.docker.com/r/apache/pegasus/tags



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] foreverneverer closed pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
foreverneverer closed pull request #1017: build(thirdparty): add thirdparty for centos6 build env 
URL: https://github.com/apache/incubator-pegasus/pull/1017


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org


[GitHub] [incubator-pegasus] foreverneverer merged pull request #1017: build(thirdparty): add thirdparty for centos6 build env

Posted by GitBox <gi...@apache.org>.
foreverneverer merged PR #1017:
URL: https://github.com/apache/incubator-pegasus/pull/1017


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org