You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by ju...@apache.org on 2015/09/04 08:12:27 UTC
incubator-reef git commit: [REEF-677] Made ITaskMessage immutable
Repository: incubator-reef
Updated Branches:
refs/heads/master bd9326aab -> 8587b42dc
[REEF-677] Made ITaskMessage immutable
JIRA:
[REEF-677](https://issues.apache.org/jira/browse/REEF-677)
This Closes #463
Author: Markus Weimer <we...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/8587b42d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/8587b42d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/8587b42d
Branch: refs/heads/master
Commit: 8587b42dca38dbc96ead93138b603a894671ec28
Parents: bd9326a
Author: Markus Weimer <we...@apache.org>
Authored: Thu Sep 3 12:16:33 2015 -0700
Committer: Julia Wang <jw...@yahoo.com>
Committed: Thu Sep 3 23:07:26 2015 -0700
----------------------------------------------------------------------
.../Bridge/Events/TaskMessage.cs | 18 +++---------------
.../Org.Apache.REEF.Driver/Task/ITaskMessage.cs | 15 ++++++++++++---
2 files changed, 15 insertions(+), 18 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/8587b42d/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/TaskMessage.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/TaskMessage.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/TaskMessage.cs
index b2f8caa..b8f3fba 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/TaskMessage.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/TaskMessage.cs
@@ -17,7 +17,6 @@
* under the License.
*/
-using System;
using System.Runtime.Serialization;
using Org.Apache.REEF.Driver.Bridge.Clr2java;
using Org.Apache.REEF.Driver.Task;
@@ -30,36 +29,25 @@ namespace Org.Apache.REEF.Driver.Bridge.Events
[DataContract]
internal class TaskMessage : ITaskMessage
{
+ private readonly byte[] _message;
private readonly ITaskMessageClr2Java _taskMessageClr2Java;
- private byte[] _message;
- private string _instanceId;
- public TaskMessage(ITaskMessageClr2Java clr2Java, byte[] message)
+ internal TaskMessage(ITaskMessageClr2Java clr2Java, byte[] message)
{
- _instanceId = Guid.NewGuid().ToString("N");
_taskMessageClr2Java = clr2Java;
_message = message;
}
[DataMember]
- public string InstanceId
- {
- get { return _instanceId; }
- set { _instanceId = value; }
- }
-
- [DataMember]
public string TaskId
{
get { return _taskMessageClr2Java.GetId(); }
- set { }
}
[DataMember]
public byte[] Message
{
get { return _message; }
- set { _message = value; }
}
}
-}
+}
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/8587b42d/lang/cs/Org.Apache.REEF.Driver/Task/ITaskMessage.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Task/ITaskMessage.cs b/lang/cs/Org.Apache.REEF.Driver/Task/ITaskMessage.cs
index e06c8f3..1df60ab 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Task/ITaskMessage.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Task/ITaskMessage.cs
@@ -19,10 +19,19 @@
namespace Org.Apache.REEF.Driver.Task
{
+ /// <summary>
+ /// Driver-side representation of a message sent from a Task to the Driver.
+ /// </summary>
public interface ITaskMessage
{
- byte[] Message { get; set; }
+ /// <summary>
+ /// The actual message sent.
+ /// </summary>
+ byte[] Message { get; }
- string TaskId { get; set; }
+ /// <summary>
+ /// The ID of the task that sent the message.
+ /// </summary>
+ string TaskId { get; }
}
-}
+}
\ No newline at end of file