You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/10/11 16:36:16 UTC
[PR] fix: [branch-1.1] make Iceberg delete-file reflection failures fatal (#5515) [datafusion-comet]
andygrove opened a new pull request, #6874:
URL: https://github.com/apache/datafusion-comet/pull/6874
## Which issue does this PR close?
Closes #5256.
Backport of #5515 to `branch-1.1`.
## Rationale for this change
Once an Iceberg scan is committed to native execution, silently guessing required delete-file metadata after reflection failures can leak deleted rows or apply deletes incorrectly. These failures must be fatal in the 1.1 release line.
## What changes are included in this PR?
Cherry-picks #5515 with `-x`. Delete-file serialization is factored into a testable helper; required content, spec ID, equality IDs, and path accessors now propagate failures, and equality deletes require non-empty equality IDs.
The branch-specific adaptation preserves the 1.1 deletion-vector and encryption metadata handling inside the new strict helper, rather than replacing that later branch code with the source PR's older context.
## How are these changes tested?
Ran:
```text
./mvnw test -Dtest=none -Dsuites='org.apache.comet.serde.operator.CometIcebergNativeScanSuite' -Dscalastyle.skip=true
```
Result: 1 suite completed, 24 tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: [branch-1.1] make Iceberg delete-file reflection failures fatal (#5515) [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #6874:
URL: https://github.com/apache/datafusion-comet/pull/6874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org