You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/06/24 14:50:08 UTC

[GitHub] [spark] srowen commented on issue #24920: [SPARK-28117][ML] LDA and BisectingKMeans cache the input dataset if necessary

srowen commented on issue #24920: [SPARK-28117][ML] LDA and BisectingKMeans cache the input dataset if necessary
URL: https://github.com/apache/spark/pull/24920#issuecomment-505044060
 
 
   We may need to adjust the test, but I wouldn't disable it. I doubt data is changed, but it may be that caching means the data _doesn't_ change on each iteration. You could simply remove the assertion that there are less than 5 clusters, as I don't see that this is what the test is testing, nor is it invalid to end up with 5 clusters here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org