You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Igor Vaynberg (JIRA)" <ji...@apache.org> on 2007/05/02 09:44:15 UTC

[jira] Commented: (WICKET-175) Page.onDetach is called by each ComponentResourceRequestTarget

    [ https://issues.apache.org/jira/browse/WICKET-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493026 ] 

Igor Vaynberg commented on WICKET-175:
--------------------------------------

can we close this since attach/detach was refactored in 1.3?

> Page.onDetach is called by each ComponentResourceRequestTarget
> --------------------------------------------------------------
>
>                 Key: WICKET-175
>                 URL: https://issues.apache.org/jira/browse/WICKET-175
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3, 2.0
>            Reporter: Alastair Maw
>             Fix For: 1.3, 2.0
>
>
> ComponentResourceRequestTarget#detach(RequestCycle) calls page#internalDetach()
> This results in Page#onDetach() being called as many times as there are images or whatever on your page, which seems entirely wrong. Mentioned this to ivaynberg on IRC and he said: "we should have theadlocal guards".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.