You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by xi...@apache.org on 2024/09/16 02:33:06 UTC
(nuttx) branch master updated (c16fd8c911 -> a9bc198bc3)
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
from c16fd8c911 gicv2:g_gic_init_done need to be protect
new 1a69d3c6ee cdcacm: Add cdcacm bulkout request buffer config
new e0d82fdf3a drivers/usedev: remove unnecessary mdelay because remain req info had beed push to serial buffer
new a9bc198bc3 composite.c warning
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
drivers/usbdev/Kconfig | 8 ++++++++
drivers/usbdev/cdcacm.c | 8 ++++++--
drivers/usbdev/composite.c | 2 +-
3 files changed, 15 insertions(+), 3 deletions(-)
(nuttx) 01/03: cdcacm: Add cdcacm bulkout request buffer config
Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit 1a69d3c6ee8d868086b04679a304ccdd50f55e35
Author: dongjiuzhu1 <do...@xiaomi.com>
AuthorDate: Wed Aug 2 12:19:59 2023 +0800
cdcacm: Add cdcacm bulkout request buffer config
Signed-off-by: dongjiuzhu1 <do...@xiaomi.com>
---
drivers/usbdev/Kconfig | 8 ++++++++
drivers/usbdev/cdcacm.c | 7 ++++++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/usbdev/Kconfig b/drivers/usbdev/Kconfig
index 49dd30472a..39ebe33ed8 100644
--- a/drivers/usbdev/Kconfig
+++ b/drivers/usbdev/Kconfig
@@ -649,6 +649,14 @@ config CDCACM_NWRREQS
---help---
The number of write/read requests that can be in flight
+config CDCACM_BULKOUT_REQLEN
+ int "Size of one read request buffer"
+ default 512 if USBDEV_DUALSPEED
+ default 256 if !USBDEV_DUALSPEED
+ ---help---
+ Read buffer size maybe larger than the maxpacket size. Increasing
+ the buffer size can effectively improve the transmission speed.
+
config CDCACM_BULKIN_REQLEN
int "Size of one write request buffer"
default 768 if USBDEV_DUALSPEED
diff --git a/drivers/usbdev/cdcacm.c b/drivers/usbdev/cdcacm.c
index ca7e6ea032..d0b8365d2a 100644
--- a/drivers/usbdev/cdcacm.c
+++ b/drivers/usbdev/cdcacm.c
@@ -626,7 +626,7 @@ static int cdcacm_requeue_rdrequest(FAR struct cdcacm_dev_s *priv,
/* Requeue the read request */
ep = priv->epbulkout;
- req->len = ep->maxpacket;
+ req->len = MAX(CONFIG_CDCACM_BULKOUT_REQLEN, ep->maxpacket);
ret = EP_SUBMIT(ep, req);
if (ret != OK)
{
@@ -1334,6 +1334,11 @@ static int cdcacm_bind(FAR struct usbdevclass_driver_s *driver,
reqlen = CONFIG_CDCACM_EPBULKOUT_FSSIZE;
}
+ if (CONFIG_CDCACM_BULKOUT_REQLEN > reqlen)
+ {
+ reqlen = CONFIG_CDCACM_BULKOUT_REQLEN;
+ }
+
for (i = 0; i < CONFIG_CDCACM_NRDREQS; i++)
{
rdcontainer = &priv->rdreqs[i];
(nuttx) 03/03: composite.c warning
Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit a9bc198bc38901f6a4d25e53f77936ec205dd258
Author: dongjiuzhu1 <do...@xiaomi.com>
AuthorDate: Tue Dec 19 21:48:46 2023 +0800
composite.c warning
usbdev/composite.c:649:36: warning: implicit declaration of function 'board_usbdev_pid' [-Wimplicit-function-declaration]
649 | uint16_t pid = board_usbdev_pid(); usbdev/composite.c:650:36: warning: implicit declaration of function 'board_usbdev_vid'
[-Wimplicit-function-declaration] 650 | uint16_t vid = board_usbdev_vid();
Signed-off-by: dongjiuzhu1 <do...@xiaomi.com>
---
drivers/usbdev/composite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usbdev/composite.c b/drivers/usbdev/composite.c
index 68e899a6aa..d95e61ee3d 100644
--- a/drivers/usbdev/composite.c
+++ b/drivers/usbdev/composite.c
@@ -38,7 +38,7 @@
#include <nuttx/usb/usbdev.h>
#include <nuttx/usb/usbdev_trace.h>
-#ifdef CONFIG_BOARD_USBDEV_SERIALSTR
+#if defined(CONFIG_BOARD_USBDEV_SERIALSTR) || defined(CONFIG_BOARD_USBDEV_PIDVID)
# include <nuttx/board.h>
#endif
(nuttx) 02/03: drivers/usedev: remove unnecessary mdelay because remain req info had beed push to serial buffer
Posted by xi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit e0d82fdf3a9c8418d78d3a41f95ef96dc43a034d
Author: dongjiuzhu1 <do...@xiaomi.com>
AuthorDate: Sun Apr 28 11:38:36 2024 +0800
drivers/usedev: remove unnecessary mdelay because remain req info had beed push to serial buffer
this mdelay causes cpu busy wait, affects other process running.
Signed-off-by: dongjiuzhu1 <do...@xiaomi.com>
---
drivers/usbdev/cdcacm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usbdev/cdcacm.c b/drivers/usbdev/cdcacm.c
index d0b8365d2a..efffdd1a49 100644
--- a/drivers/usbdev/cdcacm.c
+++ b/drivers/usbdev/cdcacm.c
@@ -1491,7 +1491,6 @@ static void cdcacm_unbind(FAR struct usbdevclass_driver_s *driver,
*/
cdcacm_resetconfig(priv);
- up_mdelay(50);
/* Free the pre-allocated control request */