You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Vitor-Avila (via GitHub)" <gi...@apache.org> on 2023/08/10 00:59:25 UTC
[GitHub] [superset] Vitor-Avila opened a new pull request, #24941: chore(dashboard import/export): include additional fields to export/import commands
Vitor-Avila opened a new pull request, #24941:
URL: https://github.com/apache/superset/pull/24941
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24941: chore(dashboard import/export): include additional fields to export/import commands
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24941:
URL: https://github.com/apache/superset/pull/24941#issuecomment-1672385148
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24941?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24941](https://app.codecov.io/gh/apache/superset/pull/24941?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1565763) into [master](https://app.codecov.io/gh/apache/superset/commit/ec9e9a46f2f092ce56d3ed5a8a9a3ea0214db88a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ec9e9a4) will **decrease** coverage by `10.67%`.
> Report is 5 commits behind head on master.
> The diff coverage is `34.32%`.
> :exclamation: Current head 1565763 differs from pull request most recent head 3c61ea8. Consider uploading reports for the commit 3c61ea8 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24941 +/- ##
===========================================
- Coverage 69.00% 58.33% -10.67%
===========================================
Files 1906 1906
Lines 74133 74152 +19
Branches 8208 8211 +3
===========================================
- Hits 51153 43256 -7897
- Misses 20857 28772 +7915
- Partials 2123 2124 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `54.08% <27.86%> (+<0.01%)` | :arrow_up: |
| python | `61.05% <27.86%> (-22.32%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `55.05% <27.86%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/superset/pull/24941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://app.codecov.io/gh/apache/superset/pull/24941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/dashboard/actions/hydrate.js](https://app.codecov.io/gh/apache/superset/pull/24941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2h5ZHJhdGUuanM=) | `2.04% <ø> (ø)` | |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://app.codecov.io/gh/apache/superset/pull/24941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `39.28% <ø> (ø)` | |
| [superset/cli/native\_filters.py](https://app.codecov.io/gh/apache/superset/pull/24941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY2xpL25hdGl2ZV9maWx0ZXJzLnB5) | `0.00% <0.00%> (ø)` | |
| [superset/dashboards/api.py](https://app.codecov.io/gh/apache/superset/pull/24941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `50.76% <0.00%> (-41.78%)` | :arrow_down: |
| [superset/databases/api.py](https://app.codecov.io/gh/apache/superset/pull/24941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `52.39% <ø> (-37.56%)` | :arrow_down: |
| [...uperset/utils/dashboard\_filter\_scopes\_converter.py](https://app.codecov.io/gh/apache/superset/pull/24941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ZpbHRlcl9zY29wZXNfY29udmVydGVyLnB5) | `8.54% <0.00%> (-7.25%)` | :arrow_down: |
| [superset/security/manager.py](https://app.codecov.io/gh/apache/superset/pull/24941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `62.37% <16.66%> (-32.07%)` | :arrow_down: |
| [superset/daos/dashboard.py](https://app.codecov.io/gh/apache/superset/pull/24941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGFvcy9kYXNoYm9hcmQucHk=) | `35.02% <33.33%> (-61.66%)` | :arrow_down: |
| [superset/views/core.py](https://app.codecov.io/gh/apache/superset/pull/24941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `34.00% <33.33%> (-35.47%)` | :arrow_down: |
| ... and [8 more](https://app.codecov.io/gh/apache/superset/pull/24941?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [285 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24941/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #24941: chore(dashboard import/export): include additional fields to export/import commands
Posted by "betodealmeida (via GitHub)" <gi...@apache.org>.
betodealmeida merged PR #24941:
URL: https://github.com/apache/superset/pull/24941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #24941: chore(dashboard import/export): include additional fields to export/import commands
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #24941:
URL: https://github.com/apache/superset/pull/24941#issuecomment-1673578178
Thanks @Vitor-Avila for the change. Once you fix the CI issues we can merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Vitor-Avila commented on pull request #24941: chore(dashboard import/export): include additional fields to export/import commands
Posted by "Vitor-Avila (via GitHub)" <gi...@apache.org>.
Vitor-Avila commented on PR #24941:
URL: https://github.com/apache/superset/pull/24941#issuecomment-1675242592
thanks @john-bodley! I'm not sure why that test is failing only for two DB Engines. I'm spinning up a local MySQL to further debug this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org