You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/01/25 21:39:21 UTC
[GitHub] [drill] eevanwong opened a new pull request #2155: DRILL-7712: Fix Issues after ZK upgrade
eevanwong opened a new pull request #2155:
URL: https://github.com/apache/drill/pull/2155
# [DRILL-7712](https://issues.apache.org/jira/browse/DRILL-7712): Fix Issues after ZK upgrade
## Description
Updated unit tests so that it utilizes MappingListenerManager instead of ListenerContainer from Apache Curator which was deprecated in version 5.1.0. Curator v5.1.0 fixes NPE errors in testing phase (also described in DRILL-7843(https://issues.apache.org/jira/browse/DRILL-7843).
## Documentation
N/A
## Testing
Checked mvn test and the errors that were described are no longer there.
`[INFO] Running org.apache.drill.exec.coord.zk.TestZookeeperClient
[INFO] Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.224 s - in org.apache.drill.exec.coord.zk.TestZookeeperClient
[INFO] Running org.apache.drill.exec.coord.zk.TestEphemeralStore
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.658 s - in org.apache.drill.exec.coord.zk.TestEphemeralStore
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.555 s - in org.apache.drill.yarn.zk.TestAmRegistration
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.063 s - in org.apache.drill.yarn.client.TestCommandLineOptions`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] eevanwong commented on pull request #2155: DRILL-7712: Fix Issues after ZK upgrade
Posted by GitBox <gi...@apache.org>.
eevanwong commented on pull request #2155:
URL: https://github.com/apache/drill/pull/2155#issuecomment-767652375
I'll try that out, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] eevanwong closed pull request #2155: DRILL-7712: Fix Issues after ZK upgrade
Posted by GitBox <gi...@apache.org>.
eevanwong closed pull request #2155:
URL: https://github.com/apache/drill/pull/2155
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] luocooong commented on pull request #2155: DRILL-7712: Fix Issues after ZK upgrade
Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2155:
URL: https://github.com/apache/drill/pull/2155#issuecomment-767325770
@eevanwong Thanks for the new PR. I recommend you creating new branches for the feature rather than working from your `master` branch. it will be very troublesome to merge because of saw the merged item in this commit list. here are my what i do :
```
git fetch upstream master
git checkout -b DRILL-7712 upstream/master
// do some amazing coding
git commit -m 'DRILL-7712: Title'
git push origin DRILL-7712
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org