You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@gora.apache.org by dj...@apache.org on 2020/03/13 18:37:08 UTC

[gora] branch master updated: GORA-271 Make consistent across datastores the way of getting the mapping filename (#170)

This is an automated email from the ASF dual-hosted git repository.

djkevincr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/gora.git


The following commit(s) were added to refs/heads/master by this push:
     new 51ff495  GORA-271 Make consistent across datastores the way of getting the mapping filename (#170)
51ff495 is described below

commit 51ff495ca1c0dade1ae988940d211f9d0301ecf9
Author: Lahiru Jayasekara <ml...@gmail.com>
AuthorDate: Sat Mar 14 00:06:59 2020 +0530

    GORA-271 Make consistent across datastores the way of getting the mapping filename (#170)
    
    * Fix mapping file name access method in hbaseStore
    
    * Fix mapping file name access method in dynamoDBStore
    
    * Remove unused imports

Re: [gora] branch master updated: GORA-271 Make consistent across datastores the way of getting the mapping filename (#170)

Posted by Alfonso Nishikawa <al...@gmail.com>.

Hi.

For mi this commit is not the ment for GORA-271. it was not meant to break
the functionalities and it was not related about loading from InputStream.
And it is breaking gora-pig.
In fact, loading the mapping from an InputStream was the desired way, not
loading directly from file (you just reverted!)

In my opinion, this issue should be reopened and fixed properly.

Let me know your thoughts.

Regards,

Alfonso Nishikawa



El vie., 13 mar. 2020 a las 19:37, <dj...@apache.org> escribió:

> This is an automated email from the ASF dual-hosted git repository.
>
> djkevincr pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/gora.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>      new 51ff495  GORA-271 Make consistent across datastores the way of
> getting the mapping filename (#170)
> 51ff495 is described below
>
> commit 51ff495ca1c0dade1ae988940d211f9d0301ecf9
> Author: Lahiru Jayasekara <ml...@gmail.com>
> AuthorDate: Sat Mar 14 00:06:59 2020 +0530
>
>     GORA-271 Make consistent across datastores the way of getting the
> mapping filename (#170)
>
>     * Fix mapping file name access method in hbaseStore
>
>     * Fix mapping file name access method in dynamoDBStore
>
>     * Remove unused imports
>
>