You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flink.apache.org by "Rui Fan (Jira)" <ji...@apache.org> on 2023/06/30 02:58:00 UTC

[jira] [Created] (FLINK-32495) SourceCoordinatorAlignmentTest.testWatermarkAlignmentWithTwoGroups fails

Rui Fan created FLINK-32495:
-------------------------------

Summary: SourceCoordinatorAlignmentTest.testWatermarkAlignmentWithTwoGroups fails
Key: FLINK-32495
URL: https://issues.apache.org/jira/browse/FLINK-32495
Project: Flink
Issue Type: Bug
Reporter: Rui Fan
Assignee: Rui Fan
Attachments: image-2023-06-30-10-53-50-280.png

SourceCoordinatorAlignmentTest.testWatermarkAlignmentWithTwoGroups fails.

I analyzed this CI : [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=50668&view=logs&j=a57e0635-3fad-5b08-57c7-a4142d7d6fa9&t=2ef0effc-1da1-50e5-c2bd-aab434b1c5b7&l=9089]
h1. Root cause:
* The CoordinatorExecutorThreadFactory cannot new multiple threads. And too many callers will check `coordinatorThreadFactory.isCurrentThreadCoordinatorThread()`, such as: SourceCoordinatorContext.attemptReady.
* The CoordinatorExecutorThreadFactory is shared at [SourceCoordinatorTestBase|https://github.com/apache/flink/blob/21eba4ca4cb235a2189c94cdbf3abcec5cde1e6e/flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorTestBase.java#L68]
* It will be used at multiple source coordinator, and the second source coordinator will overwrite the CoordinatorExecutorThreadFactory#t, so the check will fail for the first source.

h1. Solution:

Don't share the CoordinatorExecutorThreadFactory.
h1. log:

!image-2023-06-30-10-53-50-280.png!

--
This message was sent by Atlassian Jira
(v8.20.10#820010)