[Bug 56784] Possible atomicity violations

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=56784

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
(In reply to diogogsousa from comment #0)
> In org.apache.catalina.core.ContainerBase, method getChildren(), lines
> 1526-1534:

Technically this is valid although no-one has ever reported an issue. It is
likely that the error would only be seen by JMX clients and a refresh would fix
it. I'll get this fixed in 8.0.x for 8.0.11 onwards.

> In org.apache.catalina.core.StandardEngine, method start(), lines 438-439:

This only affects 6.0.x and I don't see any way for this to occur in normal (or
even fairly abnormal) usage. It is probably possible to trigger this if you try
really hard but I don't see a need for changes here.

> In org.apache.catalina.core.StandardContext, method addParameter(), lines
> 2659-2672:

Again this one is valid but no-one has reported an issue. I wouldn't expect to
see an issue in normal usage and concurrent threads configuring a Context would
be pretty unusual. A ConcurrentHashMap looks like it will be cleaner here so
I'll get that fixed in 8.0.x for 8.0.11 as well.

In terms of back-ports, given that we haven't had reports of any issues, I'm
leaning towards only fixing these in 8.0.x and not back-porting the changes to
earlier versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org