You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/07/22 08:33:28 UTC

Review Request 36680: Added recordio_test.cpp to libprocess Makefile.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36680/
-----------------------------------------------------------

Review request for mesos and Anand Mazumdar.


Bugs: MESOS-3067
    https://issues.apache.org/jira/browse/MESOS-3067


Repository: mesos


Description
-------

See: https://reviews.apache.org/r/36680


Diffs
-----

  3rdparty/libprocess/3rdparty/Makefile.am 856c2b289451fd404b97285b825e72913feb2f04 

Diff: https://reviews.apache.org/r/36680/diff/


Testing
-------

make check


Thanks,

Ben Mahler


Re: Review Request 36680: Added recordio_test.cpp to libprocess Makefile.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36680/#review92558
-----------------------------------------------------------


Patch looks great!

Reviews applied: [36677, 36680]

All tests passed.

- Mesos ReviewBot


On July 22, 2015, 6:33 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36680/
> -----------------------------------------------------------
> 
> (Updated July 22, 2015, 6:33 a.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Bugs: MESOS-3067
>     https://issues.apache.org/jira/browse/MESOS-3067
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See: https://reviews.apache.org/r/36680
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 856c2b289451fd404b97285b825e72913feb2f04 
> 
> Diff: https://reviews.apache.org/r/36680/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Re: Review Request 36680: Added recordio_test.cpp to libprocess Makefile.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36680/#review92629
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On July 22, 2015, 6:33 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36680/
> -----------------------------------------------------------
> 
> (Updated July 22, 2015, 6:33 a.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Bugs: MESOS-3067
>     https://issues.apache.org/jira/browse/MESOS-3067
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See: https://reviews.apache.org/r/36680
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 856c2b289451fd404b97285b825e72913feb2f04 
> 
> Diff: https://reviews.apache.org/r/36680/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>