You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2019/03/05 00:08:54 UTC
[incubator-pinot] branch fix_record_reader updated: Add comments in
RecordReaderSampleDataTest
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch fix_record_reader
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/fix_record_reader by this push:
new 1b87860 Add comments in RecordReaderSampleDataTest
1b87860 is described below
commit 1b878609046f8f89f0d68be07351a9855f01c102
Author: Jackie (Xiaotian) Jiang <xa...@linkedin.com>
AuthorDate: Mon Mar 4 16:08:43 2019 -0800
Add comments in RecordReaderSampleDataTest
---
.../apache/pinot/core/data/readers/RecordReaderSampleDataTest.java | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/pinot-core/src/test/java/org/apache/pinot/core/data/readers/RecordReaderSampleDataTest.java b/pinot-core/src/test/java/org/apache/pinot/core/data/readers/RecordReaderSampleDataTest.java
index 73aff73..94c7af3 100644
--- a/pinot-core/src/test/java/org/apache/pinot/core/data/readers/RecordReaderSampleDataTest.java
+++ b/pinot-core/src/test/java/org/apache/pinot/core/data/readers/RecordReaderSampleDataTest.java
@@ -48,15 +48,19 @@ public class RecordReaderSampleDataTest {
.addSingleValueDimension("unknown_dimension", FieldSpec.DataType.STRING)
.addMetric("met_impressionCount", FieldSpec.DataType.LONG).addMetric("unknown_metric", FieldSpec.DataType.DOUBLE)
.build();
+ // Same incoming and outgoing time column name, should read value with the incoming time data type
private final Schema SCHEMA_SAME_INCOMING_OUTGOING = new Schema.SchemaBuilder()
.addTime("time_day", TimeUnit.SECONDS, FieldSpec.DataType.LONG, "time_day", TimeUnit.DAYS, FieldSpec.DataType.INT)
.build();
+ // Different incoming and outgoing time column name, should read both incoming and outgoing time
private final Schema SCHEMA_DIFFERENT_INCOMING_OUTGOING = new Schema.SchemaBuilder()
.addTime("time_day", TimeUnit.SECONDS, FieldSpec.DataType.LONG, "column2", TimeUnit.DAYS, FieldSpec.DataType.INT)
.build();
+ // Incoming time column does not exist in the record, should read outgoing time only
private final Schema SCHEMA_NO_INCOMING = new Schema.SchemaBuilder()
.addTime("incoming", TimeUnit.SECONDS, FieldSpec.DataType.LONG, "time_day", TimeUnit.DAYS, FieldSpec.DataType.INT)
.build();
+ // Outgoing time column does not exist in the record, should read incoming time only
private final Schema SCHEMA_NO_OUTGOING = new Schema.SchemaBuilder()
.addTime("time_day", TimeUnit.SECONDS, FieldSpec.DataType.LONG, "outgoing", TimeUnit.DAYS, FieldSpec.DataType.INT)
.build();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org