You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/03/02 15:18:00 UTC

[jira] [Commented] (IMPALA-5904) Enable ThreadSanitizer for Impala

    [ https://issues.apache.org/jira/browse/IMPALA-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049307#comment-17049307 ] 

ASF subversion and git services commented on IMPALA-5904:
---------------------------------------------------------

Commit 984f675e05d83f048afbee5b8a78413b2a624d13 in impala's branch refs/heads/master from Sahil Takiar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=984f675 ]

IMPALA-5904: (part 2) Fix more TSAN bugs

Fixes the following data races reported by TSAN:

data race be/src/runtime/krpc-data-stream-sender.cc:581:3 in
KrpcDataStreamSender::Channel::SerializeAndSendBatch(impala::RowBatch*)
* Race condition when reading 'rpc_in_flight_batch_' outside of the
  'lock_'
* Since this race condition is only triggered inside a DCHECK, added a
  suppresion

data race be/src/util/stopwatch.h:183:9 in
MonotonicStopWatch::RunningTime() const
* Race condition on BlockingJoinNode::built_probe_overlap_stop_watch_;
  changed from a MonotonicStopWatch to a ConcurrentStopWatch

data race be/src/exec/kudu-scan-node.cc:211:13 in
KuduScanNode::ProcessScanToken(impala::KuduScanner*, std::string const&)
* Some reads on KuduScanNode::done_ are racey, so I made 'done_' an
  AtomicBool; this has the added benefit that failed scans will be
  aborted as soon as 'done_' is set to false

data race be/src/service/client-request-state.h:220:29 in
ClientRequestState::eos() const
* Race condition when reading / updating ClientRequestState::eos_; made
  'eos_' an AtomicBool

data race be/src/exec/parquet/parquet-column-readers.cc:497:9 in
bool ScalarColumnReader<...>::ReadValueBatch<false>(...)
* Race condition in SHOULD_TRIGGER_COL_READER_DEBUG_ACTION /
  parquet_column_reader_debug_count

data race be/src/service/impala-server.cc:817:20 in
ImpalaServer::ArchiveQuery(impala::ClientRequestState const&)
* Race condition on some ClientRequestState fields when creating a
  QueryStateRecord

Fixes IMPALA-9313: 'TSAN data race in TmpFileMgr::File::Blacklist' and
adds a suppresion for IMPALA-9404:
'Instantiations/ExprTest.MathConversionFunctions fails in TSAN builds'.

Testing:
* Ran core tests
* Re-ran TSAN tests and confirmed the data races have been fixed

Change-Id: I01feb40417dc5ea64ccb0c1044cfc3eed8508476
Reviewed-on: http://gerrit.cloudera.org:8080/15244
Reviewed-by: Sahil Takiar <st...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Enable ThreadSanitizer for Impala
> ---------------------------------
>
>                 Key: IMPALA-5904
>                 URL: https://issues.apache.org/jira/browse/IMPALA-5904
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>            Reporter: Tim Armstrong
>            Assignee: Sahil Takiar
>            Priority: Major
>              Labels: ramp-up
>         Attachments: impalad.ERROR
>
>
> It would be great to be able to automatically detect data races in Impala using ThreadSanitizer to avoid tricky-to-reproduce bugs. This issue tracks enabling ThreadSanitizer, fixing bugs and adding suppressions to get to the point where Impala runs cleanly with the sanitizer.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org