You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Pallavi Rao <pa...@inmobi.com> on 2016/01/08 10:08:36 UTC

Review Request 42064: FALCON-1662 Ensure entity can be scheduled on multiple clusters on same colo

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42064/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-1662
    https://issues.apache.org/jira/browse/FALCON-1662


Repository: falcon-git


Description
-------

Some problems that were identified while testing this have been fixed:
1. OozieWorkflowEngine isActive method had an issue.
2. The JDBCStateStore was not filtering by cluster.

Additionally, noted that update was not compliant with oozie scheduler and fixed it.


Diffs
-----

  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java cf0e30d 
  scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 5ed3ccd 
  scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java abd4119 
  scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java c9e6da4 
  scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java bb8ff61 

Diff: https://reviews.apache.org/r/42064/diff/


Testing
-------

UTs updated. Manual testing done.


Thanks,

Pallavi Rao

Re: Review Request 42064: FALCON-1662 Ensure entity can be scheduled on multiple clusters on same colo

Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42064/#review114859
-----------------------------------------------------------

Ship it!


Ship It!

- pavan kumar kolamuri


On Jan. 8, 2016, 11 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42064/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 11 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1662
>     https://issues.apache.org/jira/browse/FALCON-1662
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Some problems that were identified while testing this have been fixed:
> 1. OozieWorkflowEngine isActive method had an issue.
> 2. The JDBCStateStore was not filtering by cluster.
> 
> Additionally, noted that update was not compliant with oozie scheduler and fixed it.
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java cf0e30d 
>   scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java f45ec98 
>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 5ed3ccd 
>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java abd4119 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java c9e6da4 
>   scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java bb8ff61 
> 
> Diff: https://reviews.apache.org/r/42064/diff/
> 
> 
> Testing
> -------
> 
> UTs updated. Manual testing done.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>

Re: Review Request 42064: FALCON-1662 Ensure entity can be scheduled on multiple clusters on same colo

Posted by Ajay Yadava <aj...@gmail.com>.

> On Jan. 15, 2016, 7:46 a.m., Ajay Yadava wrote:
> > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java, line 280
> > <https://reviews.apache.org/r/42064/diff/2/?file=1187386#file1187386line280>
> >
> >     nit: you can use bundles.removeAll

Even for map, we can use keyset().removeAll to achieve same effect. Anyhow it was just a minor nit, not worth another JIRA.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42064/#review114677
-----------------------------------------------------------


On Jan. 8, 2016, 11 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42064/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 11 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1662
>     https://issues.apache.org/jira/browse/FALCON-1662
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Some problems that were identified while testing this have been fixed:
> 1. OozieWorkflowEngine isActive method had an issue.
> 2. The JDBCStateStore was not filtering by cluster.
> 
> Additionally, noted that update was not compliant with oozie scheduler and fixed it.
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java cf0e30d 
>   scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java f45ec98 
>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 5ed3ccd 
>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java abd4119 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java c9e6da4 
>   scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java bb8ff61 
> 
> Diff: https://reviews.apache.org/r/42064/diff/
> 
> 
> Testing
> -------
> 
> UTs updated. Manual testing done.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>

Re: Review Request 42064: FALCON-1662 Ensure entity can be scheduled on multiple clusters on same colo

Posted by Ajay Yadava <aj...@gmail.com>.

> On Jan. 15, 2016, 7:46 a.m., Ajay Yadava wrote:
> >

Good to go after the nit is fixed.


- Ajay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42064/#review114677
-----------------------------------------------------------


On Jan. 8, 2016, 11 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42064/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 11 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1662
>     https://issues.apache.org/jira/browse/FALCON-1662
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Some problems that were identified while testing this have been fixed:
> 1. OozieWorkflowEngine isActive method had an issue.
> 2. The JDBCStateStore was not filtering by cluster.
> 
> Additionally, noted that update was not compliant with oozie scheduler and fixed it.
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java cf0e30d 
>   scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java f45ec98 
>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 5ed3ccd 
>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java abd4119 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java c9e6da4 
>   scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java bb8ff61 
> 
> Diff: https://reviews.apache.org/r/42064/diff/
> 
> 
> Testing
> -------
> 
> UTs updated. Manual testing done.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>

Re: Review Request 42064: FALCON-1662 Ensure entity can be scheduled on multiple clusters on same colo

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42064/#review114677
-----------------------------------------------------------



oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java (line 280)
<https://reviews.apache.org/r/42064/#comment175540>

    nit: you can use bundles.removeAll


- Ajay Yadava


On Jan. 8, 2016, 11 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42064/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 11 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1662
>     https://issues.apache.org/jira/browse/FALCON-1662
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Some problems that were identified while testing this have been fixed:
> 1. OozieWorkflowEngine isActive method had an issue.
> 2. The JDBCStateStore was not filtering by cluster.
> 
> Additionally, noted that update was not compliant with oozie scheduler and fixed it.
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java cf0e30d 
>   scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java f45ec98 
>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 5ed3ccd 
>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java abd4119 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java c9e6da4 
>   scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java bb8ff61 
> 
> Diff: https://reviews.apache.org/r/42064/diff/
> 
> 
> Testing
> -------
> 
> UTs updated. Manual testing done.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>

Re: Review Request 42064: FALCON-1662 Ensure entity can be scheduled on multiple clusters on same colo

Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42064/#review114860
-----------------------------------------------------------

Ship it!


Ship It!

- pavan kumar kolamuri


On Jan. 8, 2016, 11 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42064/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 11 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1662
>     https://issues.apache.org/jira/browse/FALCON-1662
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Some problems that were identified while testing this have been fixed:
> 1. OozieWorkflowEngine isActive method had an issue.
> 2. The JDBCStateStore was not filtering by cluster.
> 
> Additionally, noted that update was not compliant with oozie scheduler and fixed it.
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java cf0e30d 
>   scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java f45ec98 
>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 5ed3ccd 
>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java abd4119 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java c9e6da4 
>   scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java bb8ff61 
> 
> Diff: https://reviews.apache.org/r/42064/diff/
> 
> 
> Testing
> -------
> 
> UTs updated. Manual testing done.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>

Re: Review Request 42064: FALCON-1662 Ensure entity can be scheduled on multiple clusters on same colo

Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42064/#review114947
-----------------------------------------------------------



oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java (line 280)
<https://reviews.apache.org/r/42064/#comment175777>

    bundles is a Map and does not have a removeAll method. Had it been a collection, could have done that.


- Pallavi Rao


On Jan. 8, 2016, 11 a.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42064/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 11 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1662
>     https://issues.apache.org/jira/browse/FALCON-1662
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Some problems that were identified while testing this have been fixed:
> 1. OozieWorkflowEngine isActive method had an issue.
> 2. The JDBCStateStore was not filtering by cluster.
> 
> Additionally, noted that update was not compliant with oozie scheduler and fixed it.
> 
> 
> Diffs
> -----
> 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java cf0e30d 
>   scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java f45ec98 
>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 5ed3ccd 
>   scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java abd4119 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java c9e6da4 
>   scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java bb8ff61 
> 
> Diff: https://reviews.apache.org/r/42064/diff/
> 
> 
> Testing
> -------
> 
> UTs updated. Manual testing done.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>

Re: Review Request 42064: FALCON-1662 Ensure entity can be scheduled on multiple clusters on same colo

Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42064/
-----------------------------------------------------------

(Updated Jan. 8, 2016, 11 a.m.)


Review request for Falcon.


Changes
-------

Made delete idempotent


Bugs: FALCON-1662
    https://issues.apache.org/jira/browse/FALCON-1662


Repository: falcon-git


Description
-------

Some problems that were identified while testing this have been fixed:
1. OozieWorkflowEngine isActive method had an issue.
2. The JDBCStateStore was not filtering by cluster.

Additionally, noted that update was not compliant with oozie scheduler and fixed it.


Diffs (updated)
-----

  oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java cf0e30d 
  scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java f45ec98 
  scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 5ed3ccd 
  scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java abd4119 
  scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java c9e6da4 
  scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java bb8ff61 

Diff: https://reviews.apache.org/r/42064/diff/


Testing
-------

UTs updated. Manual testing done.


Thanks,

Pallavi Rao