[GitHub] [cordova-plugin-media] erisu commented on pull request #316: feat!: use internal storage only due to Android 11 introducing insecure external storage for apps

[GitBox <gi...@apache.org>]

erisu commented on pull request #316:
URL: https://github.com/apache/cordova-plugin-media/pull/316#issuecomment-935397555


   @sc0ttdav3y anyways, I am not against your decision on dropping the external directory support. I also think it is a good idea, as the thread says external is less secure.
   
   I am just thinking if we should make two PRs and two releases. Both releases will support Android 11 but one will be with external support, the other will be internal only.
   
   **Maybe the ideal roadmap:**
   
   * Step 1: Merge in my PR. This would be the actual Android 11 fix for the issue on the current major release 5.x. It will maintain the current pattern of using external dir first and then fall back to internal if not mounted).
   * Step 2: Release the media plugin 5.0.4 patch. 
   * Step 3: Merge in your PR which will introduce the breaking feature change. Internal directory only support.
     * Step 3.1: MAYBE we could add in a flag that allows users to keep the old flow plan, external first and fallback to internal, but we default to internal only as you suggest and for better security.
   * Step 4: Release media plugin 6.0.0.
   
   This is kind of what I was thinking...
   
   Do you think this is a good idea?
   
   If we do not do "Step 3.1", then anyone who wants to keep using an external directory would remain on 5.0.3.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org