You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "orpiske (via GitHub)" <gi...@apache.org> on 2023/08/22 07:45:41 UTC
[GitHub] [camel] orpiske opened a new pull request, #11168: (chores) camel-core: cleanup obtaining Camel version information
orpiske opened a new pull request, #11168:
URL: https://github.com/apache/camel/pull/11168
Use the static holder pattern to obtain the Camel version without relying on manual locks and volatile variables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #11168: (chores) camel-core: cleanup obtaining Camel version information
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #11168:
URL: https://github.com/apache/camel/pull/11168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #11168: (chores) camel-core: cleanup obtaining Camel version information
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11168:
URL: https://github.com/apache/camel/pull/11168#issuecomment-1687649735
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a diff in pull request #11168: (chores) camel-core: cleanup obtaining Camel version information
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #11168:
URL: https://github.com/apache/camel/pull/11168#discussion_r1301179978
##########
core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/VersionHolder.java:
##########
@@ -0,0 +1,62 @@
+package org.apache.camel.impl.engine;
Review Comment:
Oh no, here we go again with IntelliJ messing up my settings. Thanks for the heads up!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #11168: (chores) camel-core: cleanup obtaining Camel version information
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #11168:
URL: https://github.com/apache/camel/pull/11168#discussion_r1301178676
##########
core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/VersionHolder.java:
##########
@@ -0,0 +1,62 @@
+package org.apache.camel.impl.engine;
Review Comment:
Need to add license header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org