You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jihoonson <gi...@git.apache.org> on 2015/08/31 13:09:17 UTC
[GitHub] tajo pull request: TAJO-1802: PythonScriptEngine copies controller...
GitHub user jihoonson opened a pull request:
https://github.com/apache/tajo/pull/715
TAJO-1802: PythonScriptEngine copies controller and tajo util whenever it is initialized
I've changed to copy python files exactly once before script engine is started in master. In worker, python files are treated as one of shared resources.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jihoonson/tajo-2 TAJO-1802
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/715.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #715
----
commit 37eabf2f274f8d09b34e52e511e2f1844d6d8233
Author: Jihoon Son <ji...@apache.org>
Date: 2015-08-31T09:51:40Z
TAJO-1802
commit d335fd25f2751a210fbc25ebf4360cacea0ff1f2
Author: Jihoon Son <ji...@apache.org>
Date: 2015-08-31T11:06:37Z
TAJO-1802
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1802: PythonScriptEngine copies controller...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/715#issuecomment-136973837
+1 LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1802: PythonScriptEngine copies controller...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/715#issuecomment-136937052
Thank you for the nice comment. I'll change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1802: PythonScriptEngine copies controller...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/715#issuecomment-136936987
In my opinion, once copied controller.py and tajo_util.py, It does not need to overwrite.
Can you move to TajoWorker.serviceInit and TajoMaster.serviceInit ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1802: PythonScriptEngine copies controller...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/715
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---