You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Loyal-Young (via GitHub)" <gi...@apache.org> on 2026/09/28 11:38:27 UTC

[I] [Bug] Service provider descriptors stop loading at blank or comment lines [rocketmq]

Loyal-Young opened a new issue, #11268:
URL: https://github.com/apache/rocketmq/issues/11268

   ### Before Creating the Bug Report
   
   - [x] I inspected the current develop code and searched related issues/open pull requests.
   
   ### Summary
   
   ServiceProvider.load stops at the first blank line and tries to load comments or whitespace as class names. loadClass likewise cannot find a valid provider after leading blank/comment lines.
   
   ### Steps to Reproduce
   
   Use a descriptor with leading comments, blank lines, inline comments, whitespace, and a repeated provider; load must return both unique providers and loadClass must select the first valid one.
   
   ### Expected Behavior
   
   Parse every line, strip inline comments and surrounding whitespace, skip empty entries, and deduplicate normalized provider names. Keep the existing descriptor path and ordering.
   
   ### Environment / Additional Context
   
   - Reproduced against develop commit `78b96bc5e21216cd7896efae08f90c5cde4cae53`.
   - Regression test: `ServiceProviderDescriptorTest`.
   - The regression fails before the fix and passes afterward on JDK 8.
   - Proposed change is limited to the existing implementation; no protocol or new API is introduced.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org