[GitHub] [curator] eolivelli commented on a change in pull request #367: CURATOR-574 DiscoveryService fatal error on deserializing an empty byte[] as JSON

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #367:
URL: https://github.com/apache/curator/pull/367#discussion_r440969485



##########
File path: curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceCacheImpl.java
##########
@@ -78,7 +79,7 @@ private static ExecutorService convertThreadFactory(ThreadFactory threadFactory)
 
         this.discovery = discovery;
 
-        String path = discovery.pathForName(name);
+        path = discovery.pathForName(name);

Review comment:
       @Randgalt do you think this is a regression ?
   
   I will push down the fix to CuratorCacheListener, thanks for the suggestion.
   I didn't go that way because I wasn't sure.
   
   It is important to understand if this is a regression in 5.0 and then we have to fix it asap, otherwise applications will break




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org