[GitHub] [calcite] julianhyde commented on a change in pull request #1624: [Calcite 3558] Fixing indexing variable for the column reordering loop

[GitBox <gi...@apache.org>]

julianhyde commented on a change in pull request #1624: [Calcite 3558] Fixing indexing variable for the column reordering loop
URL: https://github.com/apache/calcite/pull/1624#discussion_r353999204
 
 

 ##########
 File path: splunk/src/main/java/org/apache/calcite/adapter/splunk/SplunkPushDownRule.java
 ##########
 @@ -243,6 +243,7 @@ protected RelNode appendSearchString(
           field = topFields.get(i);
         }
         newFields.add(field);
+        i++;
       }
 
 Review comment:
   And change the commit message to the problem being fixed, not the code change you made to fix it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services