You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/06/08 19:26:20 UTC

[GitHub] [airflow] BasPH commented on a change in pull request #5362: [AIRFLOW-4669] Make airflow/dag Pylint compatible

BasPH commented on a change in pull request #5362: [AIRFLOW-4669] Make airflow/dag Pylint compatible
URL: https://github.com/apache/airflow/pull/5362#discussion_r291817115
 
 

 ##########
 File path: airflow/dag/base_dag.py
 ##########
 @@ -17,6 +17,8 @@
 # specific language governing permissions and limitations
 # under the License.
 
+"""Base classes for DAG and DagBag."""
 
 Review comment:
   Would you be okay with keeping the one-liner if it fits on a single line?
   
   So
   ```python
   """Base classes for DAG and DagBag."""
   ```
   
   If line length <= 110, otherwise:
   ```python
   """
   Docs here... line 1
   line 2
   and more
   """
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services