You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/24 16:38:24 UTC
[GitHub] [kafka] ijuma commented on a change in pull request #10203: MINOR: Prepare for Gradle 7.0
ijuma commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r582115743
##########
File path: build.gradle
##########
@@ -219,37 +215,37 @@ subprojects {
options.compilerArgs << "--release" << minJavaVersion
}
- uploadArchives {
- repositories {
- signing {
- required { shouldSign }
- sign configurations.archives
-
- // To test locally, replace mavenUrl in ~/.gradle/gradle.properties to file://localhost/tmp/myRepo/
- mavenDeployer {
- beforeDeployment { MavenDeployment deployment -> signing.signPom(deployment) }
- repository(url: "${mavenUrl}") {
- authentication(userName: "${mavenUsername}", password: "${mavenPassword}")
- }
- afterEvaluate {
- pom.artifactId = "${archivesBaseName}"
- pom.project {
- name 'Apache Kafka'
- packaging 'jar'
- url 'https://kafka.apache.org'
- licenses {
- license {
- name 'The Apache Software License, Version 2.0'
- url 'https://www.apache.org/licenses/LICENSE-2.0.txt'
- distribution 'repo'
- }
- }
- }
- }
- }
- }
- }
- }
+// uploadArchives {
+// repositories {
+// signing {
+// required { shouldSign }
+// sign configurations.archives
+//
+// // To test locally, replace mavenUrl in ~/.gradle/gradle.properties to file://localhost/tmp/myRepo/
+// mavenDeployer {
+// beforeDeployment { MavenDeployment deployment -> signing.signPom(deployment) }
+// repository(url: "${mavenUrl}") {
+// authentication(userName: "${mavenUsername}", password: "${mavenPassword}")
+// }
+// afterEvaluate {
+// pom.artifactId = "${archivesBaseName}"
+// pom.project {
+// name 'Apache Kafka'
+// packaging 'jar'
+// url 'https://kafka.apache.org'
+// licenses {
+// license {
+// name 'The Apache Software License, Version 2.0'
+// url 'https://www.apache.org/licenses/LICENSE-2.0.txt'
+// distribution 'repo'
+// }
+// }
+// }
+// }
+// }
+// }
+// }
+// }
Review comment:
Need to update this to use equivalent maven-publish configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org