[GitHub] utzig commented on a change in pull request #14: Move platform #ifdefery to

[GitBox <gi...@apache.org>]

utzig commented on a change in pull request #14: Move platform #ifdefery to <nffs/os.h>
URL: https://github.com/apache/mynewt-nffs/pull/14#discussion_r242868347
 
 

 ##########
 File path: include/nffs/os.h
 ##########
 @@ -21,9 +21,29 @@
 #define H_OS_
 
 #include <stdint.h>
-#if __ZEPHYR__
+
+#if MYNEWT
+
+#include "fs/fs.h"
+#include "fs/fs_if.h"
+struct fs_ops nffs_ops;
 
 Review comment:
   Yeah, this is a bit weird, but it is what's called a "tentative definition", so it should work as long as there is a real definition in some translation unit (which is the case). Let's say I made this a real definition, by attributing a value as in `struct fs_ops nffs_ops = { 0 };`, this would actually fail the build. I guess I will just add `extern` to the line above with the hopes of making it clearer!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services