[GitHub] [maven-wrapper-plugin] hboutemy commented on a change in pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

[GitBox <gi...@apache.org>]

hboutemy commented on a change in pull request #1:
URL: https://github.com/apache/maven-wrapper-plugin/pull/1#discussion_r753846928



##########
File path: maven-wrapper/src/main/java/org/apache/maven/wrapper/MavenWrapperMain.java
##########
@@ -0,0 +1,110 @@
+package org.apache.maven.wrapper;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Properties;
+
+/**
+ * Main entry point for the Maven Wrapper, delegating wrapper execution to {@link WrapperExecutor}.
+ *
+ * @author Hans Dockter
+ */
+public class MavenWrapperMain
+{
+    private static final String POM_PROPERTIES =
+        "/META-INF/maven/org.apache.maven.wrapper/maven-wrapper/pom.properties";
+
+    public static final String DEFAULT_MAVEN_USER_HOME = System.getProperty( "user.home" ) + "/.m2";
+
+    public static final String MVNW_VERBOSE = "MVNW_VERBOSE";
+
+    public static final String MVNW_USERNAME = "MVNW_USERNAME";
+
+    public static final String MVNW_PASSWORD = "MVNW_PASSWORD";
+
+    public static final String MVNW_REPOURL = "MVNW_REPOURL";
+
+    public static final String MVN_VERSION = "3.8.3";

Review comment:
       yes, the more I'm merging back everything in one build, the more I'm in fact reverting many changes that were done while you tried to put some pieces in Maven core
   
   you're probably right, instead of continuing the current branch, we probably better start again from original maven-wrapper history and merge maven-wrapper-plugin in it: that may be easier to get to a new stable situation
   is it what you had in mind?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org