You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/10/03 15:52:53 UTC
Re: Review Request 62638: Removed support for platforms without
O_CLOEXEC.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62638/#review186954
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Sept. 27, 2017, 10:20 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62638/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 10:20 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Jie Yu.
>
>
> Bugs: MESOS-8027
> https://issues.apache.org/jira/browse/MESOS-8027
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `O_CLOEXEC` fallback code was broken since it did not guarantee
> to include `fcntl.h` before checking for the `O_CLOEXEC` symbol.
> O_CLOEXEC is supported by all reasonably current service platforms,
> so we should not need to fall back to compatibility code. So rather
> than fixing the fallback code, we can just eliminate it.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/open.hpp c9346c62e01688f0f55811f7acbe63321b084355
> 3rdparty/stout/include/stout/os/windows/fcntl.hpp ac90bf08ccf5b594e70310e9843475502b3603a5
> 3rdparty/stout/include/stout/windows.hpp 1d865f8fd23aba0198017f0bf4be8471cfb714ed
>
>
> Diff: https://reviews.apache.org/r/62638/diff/3/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
> Manually verified that sandbox files opened through the webui get the `O_CLOEXEC` flag applied.
>
>
> Thanks,
>
> James Peach
>
>