You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HiuKwok (via GitHub)" <gi...@apache.org> on 2024/02/26 11:55:53 UTC
[PR] [SPARK-47118][BUILD] Optimise dependencies scope for `jakarta.servlet-api` and `javax.servlet-api` [spark]
HiuKwok opened a new pull request, #45258:
URL: https://github.com/apache/spark/pull/45258
### What changes were proposed in this pull request?
This is a follow up change from https://github.com/apache/spark/pull/45154, to remove redundant `<scope>` for both servlet-api as `compile` is the default scope.
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
CI build
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47170][BUILD] Optimise dependencies scope for `jakarta.servlet-api` and `javax.servlet-api` [spark]
Posted by "HiuKwok (via GitHub)" <gi...@apache.org>.
HiuKwok commented on PR #45258:
URL: https://github.com/apache/spark/pull/45258#issuecomment-1964049774
@dongjoon-hyun would you mind having a look at this, thanks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47170][BUILD][CONNECT] Remove `jakarta.servlet-api` and `javax.servlet-api` dependency scope in `connect/server` module [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #45258: [SPARK-47170][BUILD][CONNECT] Remove `jakarta.servlet-api` and `javax.servlet-api` dependency scope in `connect/server` module
URL: https://github.com/apache/spark/pull/45258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47170][BUILD][CONNECT] Remove `jakarta.servlet-api` and `javax.servlet-api` dependency scope in `connect/server` module [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45258:
URL: https://github.com/apache/spark/pull/45258#issuecomment-1964647886
Thank yo, @HiuKwok . Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org