[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #572: [#410] feat: support the hot reload of coordinator's configuration

["jerqi (via GitHub)" <gi...@apache.org>]

jerqi commented on code in PR #572:
URL: https://github.com/apache/incubator-uniffle/pull/572#discussion_r1101183992


##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java:
##########
@@ -58,7 +60,7 @@ public class SimpleClusterManager implements ClusterManager {
   private Map<String, Set<ServerNode>> tagToNodes = Maps.newConcurrentMap();
   private AtomicLong excludeLastModify = new AtomicLong(0L);
   private long heartbeatTimeout;
-  private int shuffleNodesMax;
+  private AtomicInteger shuffleNodesMax;

Review Comment:
   No, we can't guarantee the  atomicity of read data. We can read 2 new bytes and 2 old bytes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org