You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org> on 2008/06/19 19:53:45 UTC

[jira] Closed: (TAPESTRY-1997) PersistentLocale is lower-casing locales

     [ https://issues.apache.org/jira/browse/TAPESTRY-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAPESTRY-1997.
------------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0.14

Thanks again for the great detective work.

> PersistentLocale is lower-casing locales
> ----------------------------------------
>
>                 Key: TAPESTRY-1997
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1997
>             Project: Tapestry
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.0.6
>            Reporter: Geoff Callender
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.0.14
>
>
> An issue affecting localization: PersistentLocale is converting locales from mixed case to all lower case, which is useless for formatting.  For example, if page 1 sets the locale like this:
> 	@Inject
> 	private PersistentLocale _persistentLocaleService;
> 	Locale locale = Locale.UK;
> 	_persistentLocaleService.set(locale);
> 	System.out.println("locale is " + locale + " - " + locale.getDisplayName());
>  
> then this is what prints:
> 	locale is en_GB - English (United Kingdom)
> But when I'm in page 2 I get the locale and find it has mutated...
> 	Locale locale = _persistentLocaleService.get();
> 	System.out.println("locale is " + locale + " - " + locale.getDisplayName());
> ...this is what prints:
> 	locale is en_gb - en_gb
> This mutated locale in page 2 is useless for formatting.  Code like the following produces default-styling instead of the styling for en_GB:
> 	_myDateFormat = DateFormat.getDateInstance(DateFormat.LONG, locale);
> 	System.out.println(_myDateFormat.format(new Date()));
> It seems this has also adversely affected how supported-locales are declared (maybe in previous releases only).  See http://thread.gmane.org/gmane.comp.java.tapestry.user/56526/focus=56527

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


Re: [jira] Closed: (TAPESTRY-1997) PersistentLocale is lower-casing locales

Posted by Geoff Callender <ge...@gmail.com>.
Thanks, guys, for getting on top of this one.

Cheers,

Geoff

On 20/06/2008, at 3:53 AM, Howard M. Lewis Ship (JIRA) wrote:

>
>     [ https://issues.apache.org/jira/browse/TAPESTRY-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel 
>  ]
>
> Howard M. Lewis Ship closed TAPESTRY-1997.
> ------------------------------------------
>
>       Resolution: Fixed
>    Fix Version/s: 5.0.14
>
> Thanks again for the great detective work.
>
>> PersistentLocale is lower-casing locales
>> ----------------------------------------
>>
>>                Key: TAPESTRY-1997
>>                URL: https://issues.apache.org/jira/browse/TAPESTRY-1997
>>            Project: Tapestry
>>         Issue Type: Bug
>>         Components: tapestry-core
>>   Affects Versions: 5.0.6
>>           Reporter: Geoff Callender
>>           Assignee: Howard M. Lewis Ship
>>            Fix For: 5.0.14
>>
>>
>> An issue affecting localization: PersistentLocale is converting  
>> locales from mixed case to all lower case, which is useless for  
>> formatting.  For example, if page 1 sets the locale like this:
>> 	@Inject
>> 	private PersistentLocale _persistentLocaleService;
>> 	Locale locale = Locale.UK;
>> 	_persistentLocaleService.set(locale);
>> 	System.out.println("locale is " + locale + " - " +  
>> locale.getDisplayName());
>>
>> then this is what prints:
>> 	locale is en_GB - English (United Kingdom)
>> But when I'm in page 2 I get the locale and find it has mutated...
>> 	Locale locale = _persistentLocaleService.get();
>> 	System.out.println("locale is " + locale + " - " +  
>> locale.getDisplayName());
>> ...this is what prints:
>> 	locale is en_gb - en_gb
>> This mutated locale in page 2 is useless for formatting.  Code like  
>> the following produces default-styling instead of the styling for  
>> en_GB:
>> 	_myDateFormat = DateFormat.getDateInstance(DateFormat.LONG, locale);
>> 	System.out.println(_myDateFormat.format(new Date()));
>> It seems this has also adversely affected how supported-locales are  
>> declared (maybe in previous releases only).  See http://thread.gmane.org/gmane.comp.java.tapestry.user/56526/focus=56527
>
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org