You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/06/19 19:24:17 UTC

[GitHub] sijie commented on issue #1967: Non-persistent topic drop too many messages

sijie commented on issue #1967: Non-persistent topic drop too many messages
URL: https://github.com/apache/incubator-pulsar/issues/1967#issuecomment-398515709
 
 
   replied in the mailing list, copied the root cause finding here:
   
   in 2.0 there is an optimization change on grouping acknowledgements. The optimization change [here](https://github.com/apache/incubator-pulsar/commit/19dd2c502725e3b45e56541576508626c4213091#diff-debb36270f152d2533b03902f214fa9aR674) avoided delivered messages that are already "delivered".
   However I think in non-persistent topic, since we don't store entries to bookkeeper storage, we end up using 0 as ledger id and entry id. so the optimization change treats those
   messages as already "delivered" hence it never pops those messages to client even client already receive them from the wire.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services