You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Ertl (JIRA)" <ji...@apache.org> on 2011/01/25 23:01:51 UTC

[jira] Created: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

improve timestamps on resource filename by providing the possibility to add your own filename decorators
--------------------------------------------------------------------------------------------------------

                 Key: WICKET-3389
                 URL: https://issues.apache.org/jira/browse/WICKET-3389
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.5-RC1
            Reporter: Peter Ertl
            Assignee: Peter Ertl
         Attachments: timestamp_decorator.patch

Hi, wicket devs!

Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.

Currently you can just enable or disable timestamp on resource filenames by setting [true] or [false] in wicket's resource settings.

I would like to provide the possibilty to support your custom type of 

   ITimestampDecorator

so you can build your own timestamp schemes.

e.g. you could

- add message digests instead of timestamps
- have a different filename pattern for the timestamp
- do a different type of lookup for the modification time of the resources
- treat resources individually
- (...)

Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986721#action_12986721 ] 

Peter Ertl commented on WICKET-3389:
------------------------------------

@Peter Major: Exactly! :-)

> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>         Attachments: timestamp_decorator.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamp on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Peter Major (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986724#action_12986724 ] 

Peter Major commented on WICKET-3389:
-------------------------------------

The JavaDoc for addTimestamp states:
@return modified filename including a timestamp-dependant part

Can I return there a filename containing querystring (like ?<epoch>)? Or only the filename can be modified?

> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>         Attachments: timestamp_decorator.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamps on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - omit special filenames like tinyMCE's base file from timestamps (see WICKET-3379) for proper functioning
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986748#action_12986748 ] 

Peter Ertl edited comment on WICKET-3389 at 1/25/11 6:54 PM:
-------------------------------------------------------------

I uploaded an updated version of the patch which includes a 

  QueryStringTimestampDecorator

It adds the timestamp as a query string parameters (similar to what we have in wicket 1.4)

@Major Peter: This adds the capability the you just asked for :-)

      was (Author: pete):
    I added a new version of the path which includes a 

  QueryStringTimestampDecorator

that adds the timestamp as part of the query string parameters (like we had it in wicket 1.4)

@Major Peter: This adds the capability the you just asked for :-)
  
> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>         Attachments: timestamp_decorator_3.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamps on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - omit special filenames like tinyMCE's base file from timestamps (see WICKET-3379) for proper functioning
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl updated WICKET-3389:
-------------------------------

    Attachment: timestamp_decorator_3.patch

I added the ability to post-process the resource response to for example change the caching duration and visibility of the resource

> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>         Attachments: timestamp_decorator_3.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamps on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - omit special filenames like tinyMCE's base file from timestamps (see WICKET-3379) for proper functioning
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl updated WICKET-3389:
-------------------------------

    Attachment: timestamp_decorator_2.patch

I added a new version of the path which includes a 

  QueryStringTimestampDecorator

that adds the timestamp as part of the query string parameters (like we had it in wicket 1.4)



> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>         Attachments: timestamp_decorator_2.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamps on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - omit special filenames like tinyMCE's base file from timestamps (see WICKET-3379) for proper functioning
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl updated WICKET-3389:
-------------------------------

    Attachment:     (was: timestamp_decorator_2.patch)

> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>         Attachments: timestamp_decorator_2.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamps on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - omit special filenames like tinyMCE's base file from timestamps (see WICKET-3379) for proper functioning
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987157#action_12987157 ] 

Peter Ertl commented on WICKET-3389:
------------------------------------

@Major Peter:

I can't think of the perfect solution for the base javacript file issue with issue but maybe this helps:

If 

    ResourceReference.getLastModified()

for the base javascript resource returns NULL it will not be a candidate for timestamps on filenames.


> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>         Attachments: timestamp_decorator_3.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamps on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - omit special filenames like tinyMCE's base file from timestamps (see WICKET-3379) for proper functioning
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl updated WICKET-3389:
-------------------------------

    Attachment:     (was: timestamp_decorator_2.patch)

> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>         Attachments: timestamp_decorator_3.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamps on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - omit special filenames like tinyMCE's base file from timestamps (see WICKET-3379) for proper functioning
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl resolved WICKET-3389.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-RC2

Committed an initial version into trunk taking Igor's name suggestion into account.

> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>             Fix For: 1.5-RC2
>
>         Attachments: timestamp_decorator_3.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamps on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - omit special filenames like tinyMCE's base file from timestamps (see WICKET-3379) for proper functioning
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl updated WICKET-3389:
-------------------------------

    Attachment:     (was: timestamp_decorator.patch)

> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>         Attachments: timestamp_decorator_2.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamps on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - omit special filenames like tinyMCE's base file from timestamps (see WICKET-3379) for proper functioning
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Peter Major (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986716#action_12986716 ] 

Peter Major commented on WICKET-3389:
-------------------------------------

Based on the description this issue will also fix WICKET-3379.

> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>         Attachments: timestamp_decorator.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamp on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl updated WICKET-3389:
-------------------------------

    Description: 
Hi, wicket devs!

Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.

Currently you can just enable or disable timestamps on resource filenames by setting [true] or [false] in wicket's resource settings.

I would like to provide the possibilty to support your custom type of 

   ITimestampDecorator

so you can build your own timestamp schemes.

e.g. you could

- add message digests instead of timestamps
- have a different filename pattern for the timestamp
- do a different type of lookup for the modification time of the resources
- treat resources individually
- omit special filenames like tinyMCE's base file from timestamps (see WICKET-3379) for proper functioning
- (...)

Please take a look at the patch and vote for / against merging it into current 1.5.x

  was:
Hi, wicket devs!

Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.

Currently you can just enable or disable timestamp on resource filenames by setting [true] or [false] in wicket's resource settings.

I would like to provide the possibilty to support your custom type of 

   ITimestampDecorator

so you can build your own timestamp schemes.

e.g. you could

- add message digests instead of timestamps
- have a different filename pattern for the timestamp
- do a different type of lookup for the modification time of the resources
- treat resources individually
- (...)

Please take a look at the patch and vote for / against merging it into current 1.5.x


> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>         Attachments: timestamp_decorator.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamps on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - omit special filenames like tinyMCE's base file from timestamps (see WICKET-3379) for proper functioning
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986758#action_12986758 ] 

Peter Ertl edited comment on WICKET-3389 at 1/25/11 6:15 PM:
-------------------------------------------------------------

I added the ability to post-process the resource response to e.g. change the caching duration and cache visibility of the resource

      was (Author: pete):
    I added the ability to post-process the resource response to for example change the caching duration and visibility of the resource
  
> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>         Attachments: timestamp_decorator_3.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamps on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - omit special filenames like tinyMCE's base file from timestamps (see WICKET-3379) for proper functioning
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986748#action_12986748 ] 

Peter Ertl edited comment on WICKET-3389 at 1/25/11 6:17 PM:
-------------------------------------------------------------

I added a new version of the path which includes a 

  QueryStringTimestampDecorator

that adds the timestamp as part of the query string parameters (like we had it in wicket 1.4)

@Major Peter: This adds the capability the you just asked for :-)

      was (Author: pete):
    I added a new version of the path which includes a 

  QueryStringTimestampDecorator

that adds the timestamp as part of the query string parameters (like we had it in wicket 1.4)


  
> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>         Attachments: timestamp_decorator_3.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamps on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - omit special filenames like tinyMCE's base file from timestamps (see WICKET-3379) for proper functioning
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986876#action_12986876 ] 

Igor Vaynberg commented on WICKET-3389:
---------------------------------------

i like this, i would tweak some names though to make them more general and expressive

s/ITimestampDecorator/IResourceCachingStrategy
s/Timestamp/CachingStrategy/

so the setting will be IResourceSettings#get/setResourceCachingStrategy

> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>         Attachments: timestamp_decorator_3.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamps on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - omit special filenames like tinyMCE's base file from timestamps (see WICKET-3379) for proper functioning
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl updated WICKET-3389:
-------------------------------

    Attachment: timestamp_decorator.patch

> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>         Attachments: timestamp_decorator.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamp on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3389) improve timestamps on resource filename by providing the possibility to add your own filename decorators

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl updated WICKET-3389:
-------------------------------

    Attachment: timestamp_decorator_2.patch

> improve timestamps on resource filename by providing the possibility to add your own filename decorators
> --------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3389
>                 URL: https://issues.apache.org/jira/browse/WICKET-3389
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Peter Ertl
>            Assignee: Peter Ertl
>         Attachments: timestamp_decorator_2.patch
>
>
> Hi, wicket devs!
> Before finalizing 1.5 I would like to enhance the "timestamp on resources" features I recently introduced.
> Currently you can just enable or disable timestamps on resource filenames by setting [true] or [false] in wicket's resource settings.
> I would like to provide the possibilty to support your custom type of 
>    ITimestampDecorator
> so you can build your own timestamp schemes.
> e.g. you could
> - add message digests instead of timestamps
> - have a different filename pattern for the timestamp
> - do a different type of lookup for the modification time of the resources
> - treat resources individually
> - omit special filenames like tinyMCE's base file from timestamps (see WICKET-3379) for proper functioning
> - (...)
> Please take a look at the patch and vote for / against merging it into current 1.5.x

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.